From 568c87216a5ccd2482df2889f74860d481452f36 Mon Sep 17 00:00:00 2001 From: Konstantin Pogorelov Date: Sat, 25 Aug 2018 12:42:53 +0200 Subject: [PATCH] #16 remove unnecessary check for existance after new, break on error with 500 --- src/index.js | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/index.js b/src/index.js index bfcdcf0..eb033d5 100644 --- a/src/index.js +++ b/src/index.js @@ -42,17 +42,14 @@ function clusterMetrics() { const aggregatorRegistry = new promClient.AggregatorRegistry(); const metricsMiddleware = function(req, res, next) { - if (aggregatorRegistry) { - aggregatorRegistry.clusterMetrics((err, clusterMetrics) => { - if (err) { - console.error(err); - } - res.set('Content-Type', aggregatorRegistry.contentType); - res.send(clusterMetrics); - }); - } else { - return next(); + aggregatorRegistry.clusterMetrics((err, clusterMetrics) => { + if (err) { + console.error(err); + return res.sendStatus(500); } + res.set('Content-Type', aggregatorRegistry.contentType); + res.send(clusterMetrics); + }); }; return metricsMiddleware;