From 975c47a79b817b4b473f60f6b22ece2e1e55ef15 Mon Sep 17 00:00:00 2001 From: Harvey Tindall Date: Sat, 6 Dec 2025 20:14:44 +0000 Subject: [PATCH] settings: fix showing advanced ones fixes #448. --- ts/modules/settings.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/ts/modules/settings.ts b/ts/modules/settings.ts index 1382beb..5a0b5a1 100644 --- a/ts/modules/settings.ts +++ b/ts/modules/settings.ts @@ -24,6 +24,10 @@ interface settingsChangedEvent extends Event { }; } +interface advancedEvent extends Event { + detail: boolean; +} + const changedEvent = (section: string, setting: string, value: string, hidden: boolean = false) => { return new CustomEvent(`settings-${section}-${setting}`, { detail: { value: value, @@ -110,8 +114,8 @@ class DOMSetting { console.log(`dispatched settings-${this._section}-${this.setting} = ${this.valueAsString()}/${v}`); } - private _advancedListener = (event: settingsChangedEvent) => { - this.hidden = !toBool(event.detail.value); + private _advancedListener = (event: advancedEvent) => { + this.hidden = !(event.detail); } get advanced(): boolean { return this._advanced; } @@ -876,8 +880,8 @@ class sectionButton extends groupableItem { }); } - private _advancedListener = (event: settingsChangedEvent) => { - if (!toBool(event.detail.value)) { + private _advancedListener = (event: advancedEvent) => { + if (!(event.detail)) { this._el.classList.add("unfocused"); } else { this._el.classList.remove("unfocused");