diff --git a/apps/probability/distribution/fisher_distribution.cpp b/apps/probability/distribution/fisher_distribution.cpp index e22931753..97e145599 100644 --- a/apps/probability/distribution/fisher_distribution.cpp +++ b/apps/probability/distribution/fisher_distribution.cpp @@ -53,12 +53,11 @@ float FisherDistribution::evaluateAtAbscissa(float x) const { bool FisherDistribution::authorizedValueAtIndex(float x, int index) const { assert(index == 0 || index == 1); - return x > FLT_MIN; // TODO LEA Add max limit? See NormalDistribution + return x > FLT_MIN && x <= k_maxParameter; } void FisherDistribution::setParameterAtIndex(float f, int index) { TwoParameterDistribution::setParameterAtIndex(f, index); - // TODO LEA Adjust parameter if max definition ? See NormalDistribution } double FisherDistribution::cumulativeDistributiveFunctionAtAbscissa(double x) const { diff --git a/apps/probability/distribution/fisher_distribution.h b/apps/probability/distribution/fisher_distribution.h index cfe744252..e61471f4b 100644 --- a/apps/probability/distribution/fisher_distribution.h +++ b/apps/probability/distribution/fisher_distribution.h @@ -22,6 +22,7 @@ public: double cumulativeDistributiveFunctionAtAbscissa(double x) const override; double cumulativeDistributiveInverseForProbability(double * probability) override; private: + constexpr static float k_maxParameter = 144.0f; // The display works badly for d1 = d2 > 144. constexpr static float k_defaultMax = 3.0f; float mode() const; };