From 0412a45cea77557235d2fc811ce33692970a8495 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?L=C3=A9a=20Saviot?= <lea.saviot@numworks.com>
Date: Thu, 19 Dec 2019 15:36:57 +0100
Subject: [PATCH] [escher/responder] Inline some methods

---
 escher/include/escher/responder.h | 14 +++++++-------
 escher/src/responder.cpp          | 24 ------------------------
 2 files changed, 7 insertions(+), 31 deletions(-)

diff --git a/escher/include/escher/responder.h b/escher/include/escher/responder.h
index cf84840bb..c8315c5bb 100644
--- a/escher/include/escher/responder.h
+++ b/escher/include/escher/responder.h
@@ -5,15 +5,15 @@
 
 class Responder {
 public:
-  Responder(Responder * parentResponder);
+  Responder(Responder * parentResponder) : m_parentResponder(parentResponder) {}
   virtual bool handleEvent(Ion::Events::Event event) { return false; }; // Default implementation does nothing
-  virtual void didBecomeFirstResponder();
-  virtual void willResignFirstResponder();
-  virtual void didEnterResponderChain(Responder * previousFirstResponder);
-  virtual void willExitResponderChain(Responder * nextFirstResponder);
-  Responder * parentResponder() const;
+  virtual void didBecomeFirstResponder() {}
+  virtual void willResignFirstResponder() {}
+  virtual void didEnterResponderChain(Responder * previousFirstResponder) {}
+  virtual void willExitResponderChain(Responder * nextFirstResponder) {}
+  Responder * parentResponder() const { return m_parentResponder; }
   Responder * commonAncestorWith(Responder * responder);
-  void setParentResponder(Responder * responder);
+  void setParentResponder(Responder * responder) { m_parentResponder = responder; }
 private:
   Responder * m_parentResponder;
 };
diff --git a/escher/src/responder.cpp b/escher/src/responder.cpp
index 34cbd96a0..ba0a120f4 100644
--- a/escher/src/responder.cpp
+++ b/escher/src/responder.cpp
@@ -2,30 +2,6 @@
 #include <escher/container.h>
 #include <assert.h>
 
-Responder::Responder(Responder * parentResponder) :
-  m_parentResponder(parentResponder)
-{
-}
-
-Responder * Responder::parentResponder() const {
-  return m_parentResponder;
-}
-
-void Responder::setParentResponder(Responder * responder) {
-  m_parentResponder = responder;
-}
-
-void Responder::didBecomeFirstResponder() {
-}
-
-void Responder::willResignFirstResponder() {
-}
-
-void Responder::didEnterResponderChain(Responder * previousFirstResponder) {
-}
-
-void Responder::willExitResponderChain(Responder * nextFirstResponder) {
-}
 
 Responder * Responder::commonAncestorWith(Responder * responder) {
   if (responder == nullptr) {