From 07af06aaad16566d76a2feb6287f62aa3ce94794 Mon Sep 17 00:00:00 2001 From: Ruben Dashyan Date: Fri, 19 Jul 2019 15:50:41 +0200 Subject: [PATCH] [apps/*/expression_model_store] Remove virtual symbol and unknownSymbol methods --- apps/graph/cartesian_function_store.h | 2 -- apps/sequence/sequence_store.h | 2 -- apps/shared/expression_model_store.h | 2 -- 3 files changed, 6 deletions(-) diff --git a/apps/graph/cartesian_function_store.h b/apps/graph/cartesian_function_store.h index 365de72ab..62c7e136f 100644 --- a/apps/graph/cartesian_function_store.h +++ b/apps/graph/cartesian_function_store.h @@ -11,8 +11,6 @@ namespace Graph { class CartesianFunctionStore : public Shared::FunctionStore { public: Shared::ExpiringPointer modelForRecord(Ion::Storage::Record record) const { return Shared::ExpiringPointer(static_cast(privateModelForRecord(record))); } - CodePoint symbol() const override { return Shared::CartesianFunction::Symbol(); } - CodePoint unknownSymbol() const override { return UCodePointUnknownX; } private: Ion::Storage::Record::ErrorStatus addEmptyModel() override; const char * modelExtension() const override { return Ion::Storage::funcExtension; } diff --git a/apps/sequence/sequence_store.h b/apps/sequence/sequence_store.h index 5f5a27a4b..dd6346ee9 100644 --- a/apps/sequence/sequence_store.h +++ b/apps/sequence/sequence_store.h @@ -12,8 +12,6 @@ namespace Sequence { class SequenceStore : public Shared::FunctionStore { public: using Shared::FunctionStore::FunctionStore; - CodePoint symbol() const override { return Sequence::Symbol(); } - CodePoint unknownSymbol() const override { return UCodePointUnknownN; } /* Sequence Store hold all its Sequences in an array. The Sequence pointers * return by modelForRecord are therefore non-expirable. We choose to return * Sequence * instead of ExpiringPointer. */ diff --git a/apps/shared/expression_model_store.h b/apps/shared/expression_model_store.h index 2cf45424d..4a1adbf25 100644 --- a/apps/shared/expression_model_store.h +++ b/apps/shared/expression_model_store.h @@ -14,8 +14,6 @@ class ExpressionModelStore { // TODO find better name (once we remove ExpressionModelStore?) public: ExpressionModelStore(); - virtual CodePoint symbol() const { return 0; } - virtual CodePoint unknownSymbol() const { return 0; } // Getters // By default, the number of models is not bounded