UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-20 01:08:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps] Replace magic numbers by constants

Browse Source 
Change-Id: If9cb40bdc9b1e88a941a6f230fb42164b1e2d5f0
This commit is contained in:
Émilie Feral
2016-10-27 16:52:01 +02:00
parent d8179abd77
commit 0913798faf
8 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apps/graph/values/values_parameter_controller.cpp
View File

@@ -1,5 +1,6 @@
#include "values_parameter_controller.h"
#include "../app.h"
#include "../../constant.h"
#include <assert.h>
namespace Graph {
@@ -38,18 +39,18 @@ int ValuesParameterController::activeCell() {
void ValuesParameterController::willDisplayCellForIndex(TableViewCell * cell, int index) {
TextMenuListCell * myCell = (TextMenuListCell *) cell;
char buffer[14];
char buffer[Constant::FloatBufferSizeInScientificMode];
switch (index) {
case 0:
Float(m_interval->start()).convertFloatToText(buffer, 14, 7);
Float(m_interval->start()).convertFloatToText(buffer, Constant::FloatBufferSizeInScientificMode, Constant::NumberOfDigitsInMantissaInScientificMode);
myCell->setText(buffer);
break;
case 1:
Float(m_interval->end()).convertFloatToText(buffer, 14, 7);
Float(m_interval->end()).convertFloatToText(buffer, Constant::FloatBufferSizeInScientificMode, Constant::NumberOfDigitsInMantissaInScientificMode);
myCell->setText(buffer);
break;
case 2:
Float(m_interval->step()).convertFloatToText(buffer, 14, 7);
Float(m_interval->step()).convertFloatToText(buffer, Constant::FloatBufferSizeInScientificMode, Constant::NumberOfDigitsInMantissaInScientificMode);
myCell->setText(buffer);
break;
default:
@@ -92,7 +93,7 @@ void ValuesParameterController::editInterval(bool overwrite, char initialDigit)
/* This code assumes that the active cell remains the one which is edited
* until the invocation is performed. This could lead to concurrency issue in
* other cases. */
char initialTextContent[16];
char initialTextContent[Constant::FloatBufferSizeInScientificMode];
if (overwrite) {
initialTextContent[0] = initialDigit;
initialTextContent[1] = 0;