UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-29 19:49:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix HistoryViewCell and ScrollableExactApproximateExxpressionsCell margins issue

Browse Source 
Remove all margins from those cells.
Rather add margins to their respective subviews:
 - ScrollableExpressionView
 - ScrollableExactApproximateExpressionsView.

As a notable consequence, the distance in HistoryViewCell between its
subviews becomes 10 instead of 5.

In passing, replace
 - Metric::HistoryHorizontalMargin = 10
 - ScrollableExactApproximateExpressionsView::k_digitHorizontalMargin = 10
 - HistoryViewCell::k_digitVerticalMargin = 5
 - ScrollableExactApproximateExpressionsCell::k_margin = 5
by
 - Metric::CommonSmallMargin = 5
 - Metric::CommonLargeMargin = 10.
This commit is contained in:
Ruben Dashyan
2019-02-15 11:49:20 +01:00
committed by EmilieNumworks
parent 571967088e
commit 0943406263
11 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/calculation/scrollable_expression_view.cpp
View File

@@ -9,7 +9,12 @@ ScrollableExpressionView::ScrollableExpressionView(Responder * parentResponder)
m_expressionView()
{
setDecoratorType(ScrollView::Decorator::Type::Arrows);
setMargins(0, Metric::HistoryHorizontalMargin, 0, Metric::HistoryHorizontalMargin);
setMargins(
Metric::CommonSmallMargin,
Metric::CommonLargeMargin,
Metric::CommonSmallMargin,
Metric::CommonLargeMargin
);
}
void ScrollableExpressionView::setLayout(Layout layout) {