From 0f61b2ccf3169c62b10ff9641d56ea30cdfe0112 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Fri, 15 May 2020 11:24:06 +0200 Subject: [PATCH] [ion] Add comment on default collectRegisters implementation --- ion/src/shared/collect_registers.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ion/src/shared/collect_registers.cpp b/ion/src/shared/collect_registers.cpp index 2083f6969..960fd0423 100644 --- a/ion/src/shared/collect_registers.cpp +++ b/ion/src/shared/collect_registers.cpp @@ -7,6 +7,10 @@ namespace Ion { * LTO inlining can make regs lower on the stack than some just-allocated * pointers. */ __attribute__((noinline))uintptr_t collectRegisters(jmp_buf buf) { + /* TODO: we use setjmp to get the registers values to look for python heap + * root. However, the 'setjmp' does not guarantee that it gets all registers + * values. We should check our setjmp implementation for the device and + * ensure that it also works for other platforms. */ setjmp(buf); int dummy; return (uintptr_t)&dummy;