From 13391d486e3546b8b7e13c66d593487472eef4b7 Mon Sep 17 00:00:00 2001 From: Ruben Dashyan Date: Mon, 10 Feb 2020 12:54:12 +0100 Subject: [PATCH] [poincare/n_ary_expression] Do not compute numberOfChildren repeatedly --- poincare/src/n_ary_expression.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/poincare/src/n_ary_expression.cpp b/poincare/src/n_ary_expression.cpp index 8cd1283b1..495529416 100644 --- a/poincare/src/n_ary_expression.cpp +++ b/poincare/src/n_ary_expression.cpp @@ -25,9 +25,10 @@ bool NAryExpressionNode::childAtIndexNeedsUserParentheses(const Expression & chi void NAryExpressionNode::sortChildrenInPlace(ExpressionOrder order, Context * context, bool canSwapMatrices, bool canBeInterrupted) { Expression reference(this); - for (int i = 1; i < reference.numberOfChildren(); i++) { + const int childrenCount = reference.numberOfChildren(); + for (int i = 1; i < childrenCount; i++) { bool isSorted = true; - for (int j = 0; j < reference.numberOfChildren()-1; j++) { + for (int j = 0; j < childrenCount-1; j++) { /* Warning: Matrix operations are not always commutative (ie, * multiplication) so we never swap 2 matrices. */ ExpressionNode * cj = childAtIndex(j);