From 13b2deb714c7c125ed07fa0acfe8000ea2acb2c8 Mon Sep 17 00:00:00 2001 From: LeaNumworks <32390188+LeaNumworks@users.noreply.github.com> Date: Thu, 12 Mar 2020 14:13:39 +0100 Subject: [PATCH] [poincare/approximation_helper] Clearer code This should do the same output. --- poincare/src/approximation_helper.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/poincare/src/approximation_helper.cpp b/poincare/src/approximation_helper.cpp index 9c498f4ce..61c5f8d20 100644 --- a/poincare/src/approximation_helper.cpp +++ b/poincare/src/approximation_helper.cpp @@ -19,9 +19,10 @@ template < typename T> T minimalNonNullMagnitudeOfParts(std::complex c) { T absRealInput = std::fabs(c.real()); T absImagInput = std::fabs(c.imag()); // If the magnitude of one part is null, ignore it - absRealInput = absRealInput > 0.0 ? absRealInput : absImagInput; - absImagInput = absImagInput > 0.0 ? absImagInput : absRealInput; - return absRealInput > absImagInput ? absImagInput : absRealInput; + if (absRealInput == 0.0 || (absImagInput > 0.0 && absImagInput < absRealInput)) { + return absImagInput; + } + return absRealInput; } static inline int absInt(int x) { return x < 0 ? -x : x; }