UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-18 16:27:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/trigonometry] Add comments

Browse Source
This commit is contained in:
Gabriel Ozouf
2020-12-04 11:38:46 +01:00
committed by EmilieNumworks
parent 1f0a18f94c
commit 1a47207bee
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
poincare/include/poincare/trigonometry.h
View File

@@ -16,6 +16,8 @@ public:
static bool isDirectTrigonometryFunction(const Expression & e); static bool isDirectTrigonometryFunction(const Expression & e);
static bool isInverseTrigonometryFunction(const Expression & e); static bool isInverseTrigonometryFunction(const Expression & e);
static bool AreInverseFunctions(const Expression & directFunction, const Expression & inverseFunction); static bool AreInverseFunctions(const Expression & directFunction, const Expression & inverseFunction);
/* Returns a (unreduced) division between pi in each unit, or 1 if the units
* are the same. */
static Expression UnitConversionFactor(Preferences::AngleUnit fromUnit, Preferences::AngleUnit toUnit); static Expression UnitConversionFactor(Preferences::AngleUnit fromUnit, Preferences::AngleUnit toUnit);
static bool ExpressionIsEquivalentToTangent(const Expression & e); static bool ExpressionIsEquivalentToTangent(const Expression & e);
static Expression shallowReduceDirectFunction(Expression & e, ExpressionNode::ReductionContext reductionContext); static Expression shallowReduceDirectFunction(Expression & e, ExpressionNode::ReductionContext reductionContext);

1
poincare/src/trigonometry.cpp
View File

@@ -90,6 +90,7 @@ bool Trigonometry::AreInverseFunctions(const Expression & directFunction, const
Expression Trigonometry::UnitConversionFactor(Preferences::AngleUnit fromUnit, Preferences::AngleUnit toUnit) { Expression Trigonometry::UnitConversionFactor(Preferences::AngleUnit fromUnit, Preferences::AngleUnit toUnit) {
if (fromUnit == toUnit) { if (fromUnit == toUnit) {
// Just an optimisation to gain some time at reduction
return Rational::Builder(1); return Rational::Builder(1);
} }
return Division::Builder(piExpression(toUnit), piExpression(fromUnit)); return Division::Builder(piExpression(toUnit), piExpression(fromUnit));