From 202beb3b13ac5a5da7f8e57d57769ae1e0cd3380 Mon Sep 17 00:00:00 2001 From: Ruben Dashyan Date: Wed, 19 Feb 2020 11:39:02 +0100 Subject: [PATCH] [poincare/unit] Add comment about namespace and scope usage --- poincare/include/poincare/unit.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/poincare/include/poincare/unit.h b/poincare/include/poincare/unit.h index 2f2340074..486ab91df 100644 --- a/poincare/include/poincare/unit.h +++ b/poincare/include/poincare/unit.h @@ -17,6 +17,16 @@ public: * - a list of allowed output prefixes * Given a Dimension, a representative in that Dimension and a Prefix * allowed for that representative, one may get a symbol and an Expression. + * + * FIXME ? + * The UnitNode class holds as members pointers to a Dimension, a + * Representative, a Prefix. Those nested classes may not be forward + * declared and must be defined in UnitNode and then aliased in Unit so as + * to be used outside. That technical limitation could have been avoided if + * UnitNode were itself a nested class of Unit, say Unit::Node. More + * generally, turning all the Poincare::...Node classes into nested + * Poincare::...::Node classes might be a more clever usage of namespaces + * and scopes. */ // There are 7 base units from which all other units are derived.