From 257194507c832d6bab360b56a3edfdfd2c796633 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Fri, 14 Sep 2018 18:07:58 +0200 Subject: [PATCH] [poincare] Integer: avoid invalid read --- poincare/src/integer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/poincare/src/integer.cpp b/poincare/src/integer.cpp index 6feafa302..1877f7ed6 100644 --- a/poincare/src/integer.cpp +++ b/poincare/src/integer.cpp @@ -484,7 +484,7 @@ Integer Integer::multiplication(const Integer & a, const Integer & b, bool oneDi } } } - while (digits[size-1] == 0 && size>0) { + while (size>0 && digits[size-1] == 0) { size--; } return Integer(digits, size, a.m_negative != b.m_negative, oneDigitOverflow); @@ -541,7 +541,7 @@ Integer Integer::usum(const Integer & a, const Integer & b, bool subtract, bool } } size = min(size, k_maxNumberOfDigits+oneDigitOverflow); - while (digits[size-1] == 0 && size>0) { + while (size>0 && digits[size-1] == 0) { size--; } return Integer(digits, size, false, oneDigitOverflow);