From 2e59e21e4edc8c5f60be261fdcde3ebea74b7b60 Mon Sep 17 00:00:00 2001 From: Romain Goyet Date: Mon, 1 May 2017 15:17:53 +0200 Subject: [PATCH] [ion] Avoid negation in getter Change-Id: Id700e80a57cf0bc828c101ad2e6d52492549d943 --- ion/src/shared/events.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ion/src/shared/events.cpp b/ion/src/shared/events.cpp index 0a888188a..4cd272a6b 100644 --- a/ion/src/shared/events.cpp +++ b/ion/src/shared/events.cpp @@ -12,7 +12,7 @@ public: static constexpr EventData Undefined() { return EventData(nullptr); } static constexpr EventData Textless() { return EventData(k_textless); } static constexpr EventData Text(const char * text) { return EventData(text); } - bool isUndefined() const { return (m_data == nullptr); } + bool isDefined() const { return (m_data != nullptr); } const char * text() const; private: static constexpr const char * k_textless = ""; @@ -105,7 +105,7 @@ Event::Event(Keyboard::Key key, bool shift, bool alpha) { do { offset = fallbackOffset[i++]; m_id = offset + (int)key; - } while (offset > 0 && s_dataForEvent[m_id].isUndefined() && m_id < k_numberOfEvents); + } while (offset > 0 && !s_dataForEvent[m_id].isDefined() && m_id < k_numberOfEvents); assert(m_id != Events::None.m_id); }