From 4dd7d1d792522645c306bac7e1a1820cf233c0cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Mon, 13 May 2019 17:54:45 +0200 Subject: [PATCH] [escher] ExpressionView: discard optimization that triggers a bug --- escher/src/expression_view.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/escher/src/expression_view.cpp b/escher/src/expression_view.cpp index 64cf5c47f..f44d9b5b9 100644 --- a/escher/src/expression_view.cpp +++ b/escher/src/expression_view.cpp @@ -15,9 +15,13 @@ ExpressionView::ExpressionView(float horizontalAlignment, float verticalAlignmen } bool ExpressionView::setLayout(Layout layoutR) { - if (m_layout.isIdenticalTo(layoutR)) { + /* TODO: this would avoid some useless redrawing. However, when we call + * setLayout after raising an Exception that led to erase all + * Poincare::TreePool, accessing m_layout will result in an ACCESS ERROR. + * How do we avoid that? */ + /*if (m_layout.isIdenticalTo(layoutR)) { return false; - } + }*/ m_layout = layoutR; markRectAsDirty(bounds()); return true;