UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 16:57:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps/shared] Fix ExpressionListController: the cell heights memoization

Browse Source 
was corrupted
This commit is contained in:
Émilie Feral
2019-07-10 17:28:53 +02:00
committed by LeaNumworks
parent c7bde32d65
commit 7891cf4182
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/shared/expression_model_list_controller.cpp
View File

@@ -19,8 +19,12 @@ ExpressionModelListController::ExpressionModelListController(Responder * parentR
void ExpressionModelListController::tableViewDidChangeSelection(SelectableTableView * t, int previousSelectedCellX, int previousSelectedCellY, bool withinTemporarySelection) {
int currentSelectedRow = selectedRow();
// Update m_cumulatedHeightForSelectedIndex if we scrolled one cell up/down
if (currentSelectedRow >= 0 && currentSelectedRow == previousSelectedCellY + 1) {
/* Update m_cumulatedHeightForSelectedIndex if we scrolled one cell up/down.
* We want previousSelectedCellY >= 0 and currentSelectedRow >= 0 to ensure
* that a cell is selected before and after the change.
* (previousSelectedCellY >= 0 condition is enough as
* currentSelectedRow > previousSelectedCellY) */
if (previousSelectedCellY >= 0 && currentSelectedRow == previousSelectedCellY + 1) {
/* We selected the cell under the previous cell. Shift the memoized cell
* heights. */
shiftMemoization(true);
@@ -32,6 +36,8 @@ void ExpressionModelListController::tableViewDidChangeSelection(SelectableTableV
assert(currentSelectedRow == 0);
m_cumulatedHeightForSelectedIndex = 0;
}
/* We ensure that a cell is selected before and after the selection change by
* checking that previousSelectedCellY > currentSelectedRow >= 0. */
} else if (currentSelectedRow >= 0 && currentSelectedRow == previousSelectedCellY - 1) {
/* We selected the cell above the previous cell. Shift the memoized cell
* heights. */