UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-19 22:00:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

[shared] Revert: Use Simplify instead of Reduce

Browse Source 
To approximate an expression, it is more precise to
approximate its simplified form than its reduced form. Indeed, we want
to minimize the number of nodes in the expression before approximating.
For instance, a/b has fewer nodes than a*b^-1.
This commit is contained in:
Émilie Feral
2018-12-17 18:01:52 +01:00
committed by LeaNumworks
parent 9a254eb78b
commit 78e4c9066f
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/sequence/sequence.cpp
View File

@@ -96,14 +96,14 @@ void Sequence::setInitialRank(int rank) {
Poincare::Expression Sequence::firstInitialConditionExpression(Context * context) const {
if (m_firstInitialConditionExpression.isUninitialized()) {
m_firstInitialConditionExpression = PoincareHelpers::ParseAndReduce(m_firstInitialConditionText, *context);
m_firstInitialConditionExpression = PoincareHelpers::ParseAndSimplify(m_firstInitialConditionText, *context);
}
return m_firstInitialConditionExpression;
}
Poincare::Expression Sequence::secondInitialConditionExpression(Context * context) const {
if (m_secondInitialConditionExpression.isUninitialized()) {
m_secondInitialConditionExpression = PoincareHelpers::ParseAndReduce(m_secondInitialConditionText, *context);
m_secondInitialConditionExpression = PoincareHelpers::ParseAndSimplify(m_secondInitialConditionText, *context);
}
return m_secondInitialConditionExpression;
}