From 7a977f5689b95d6384acaae615a49fe7775bab68 Mon Sep 17 00:00:00 2001 From: Ruben Dashyan Date: Thu, 7 Feb 2019 16:13:03 +0100 Subject: [PATCH] [apps/calculation] Remove redundancy In HistoryController::willDisplayCellForIndex, both setCalculation and reloadCell end up calling ScrollableExpressionView::layoutSubviews. Indeed, setCalculation calls setLayout over m_inputView, which in turn calls layoutSubviews. It is logical to remove the first occurence. --- apps/calculation/scrollable_expression_view.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/calculation/scrollable_expression_view.cpp b/apps/calculation/scrollable_expression_view.cpp index aa35d956f..692662014 100644 --- a/apps/calculation/scrollable_expression_view.cpp +++ b/apps/calculation/scrollable_expression_view.cpp @@ -12,7 +12,6 @@ ScrollableExpressionView::ScrollableExpressionView(Responder * parentResponder) void ScrollableExpressionView::setLayout(Layout layout) { m_expressionView.setLayout(layout); - layoutSubviews(); } void ScrollableExpressionView::setBackgroundColor(KDColor backgroundColor) {