[apps] Remove modelVersion from curves apps

The graph range used to be reset to default whenever all functions were
modified. As we no longer want to reset the range without the user's
input, we do not need to track whether the functions changed at all.

/!\ As of this commit, there is no longer a way to restore the default
zoom, until a new automatic zoom button is added.

Change-Id: Ie74e8fd61e13055fa6ce2b2d1e883182d4ecffce

apps/shared/function_app.cpp

@@ -7,18 +7,13 @@ namespace Shared {
 FunctionApp::Snapshot::Snapshot() :
   m_cursor(),
   m_indexFunctionSelectedByCursor(0),
-  m_modelVersion(0),
   m_rangeVersion(0),
   m_angleUnitVersion(Preferences::AngleUnit::Radian)
 {
-  assert(m_previousModelsVersions[0] == 0);
 }
 
 void FunctionApp::Snapshot::reset() {
   m_indexFunctionSelectedByCursor = 0;
-  m_modelVersion = 0;
-  assert(sizeof(m_previousModelsVersions) == sizeof(uint32_t) * FunctionGraphController::sNumberOfMemoizedModelVersions);
-  memset(m_previousModelsVersions, 0, sizeof(m_previousModelsVersions));
   m_rangeVersion = 0;
   setActiveTab(0);
 }

apps/shared/function_app.h

@@ -16,8 +16,6 @@ public:
   public:
     Snapshot();
     CurveViewCursor * cursor() { return &m_cursor; }
-    uint32_t * modelVersion() { return &m_modelVersion; }
-    uint32_t * previousModelsVersions() { return m_previousModelsVersions; }
     uint32_t * rangeVersion() { return &m_rangeVersion; }
     Poincare::Preferences::AngleUnit * angleUnitVersion() { return &m_angleUnitVersion; }
     virtual FunctionStore * functionStore() = 0;
@@ -28,8 +26,6 @@ public:
     CurveViewCursor m_cursor;
   private:
     int m_indexFunctionSelectedByCursor;
-    uint32_t m_modelVersion;
-    uint32_t m_previousModelsVersions[FunctionGraphController::sNumberOfMemoizedModelVersions];
     uint32_t m_rangeVersion;
     Poincare::Preferences::AngleUnit m_angleUnitVersion;
   };

apps/shared/function_graph_controller.cpp

@@ -11,8 +11,8 @@ using namespace Poincare;
 
 namespace Shared {
 
-FunctionGraphController::FunctionGraphController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, int * indexFunctionSelectedByCursor, uint32_t * modelVersion, uint32_t * previousModelsVersions, uint32_t * rangeVersion, Preferences::AngleUnit * angleUnitVersion) :
-  InteractiveCurveViewController(parentResponder, inputEventHandlerDelegate, header, interactiveRange, curveView, cursor, modelVersion, previousModelsVersions, rangeVersion),
+FunctionGraphController::FunctionGraphController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, int * indexFunctionSelectedByCursor, uint32_t * rangeVersion, Preferences::AngleUnit * angleUnitVersion) :
+  InteractiveCurveViewController(parentResponder, inputEventHandlerDelegate, header, interactiveRange, curveView, cursor, rangeVersion),
   m_angleUnitVersion(angleUnitVersion),
   m_indexFunctionSelectedByCursor(indexFunctionSelectedByCursor)
 {
@@ -120,14 +120,6 @@ CurveView * FunctionGraphController::curveView() {
   return functionGraphView();
 }
 
-uint32_t FunctionGraphController::modelVersion() {
-  return functionStore()->storeChecksum();
-}
-
-uint32_t FunctionGraphController::modelVersionAtIndex(int i) {
-  return functionStore()->storeChecksumAtIndex(i);
-}
-
 uint32_t FunctionGraphController::rangeVersion() {
   return interactiveCurveViewRange()->rangeChecksum();
 }

apps/shared/function_graph_controller.h

@@ -12,8 +12,7 @@ namespace Shared {
 
 class FunctionGraphController : public InteractiveCurveViewController, public FunctionBannerDelegate {
 public:
-  static constexpr size_t sNumberOfMemoizedModelVersions = 5;
-  FunctionGraphController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header,  InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, int * indexFunctionSelectedByCursor, uint32_t * modelVersion, uint32_t * previousModelsVersions, uint32_t * rangeVersion, Poincare::Preferences::AngleUnit * angleUnitVersion);
+  FunctionGraphController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header,  InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, int * indexFunctionSelectedByCursor, uint32_t * rangeVersion, Poincare::Preferences::AngleUnit * angleUnitVersion);
   bool isEmpty() const override;
   void didBecomeFirstResponder() override;
   void viewWillAppear() override;
@@ -50,10 +49,7 @@ private:
 
   // InteractiveCurveViewController
   bool moveCursorVertically(int direction) override;
-  uint32_t modelVersion() override;
-  uint32_t modelVersionAtIndex(int i) override;
   uint32_t rangeVersion() override;
-  size_t numberOfMemoizedVersions() const override { return sNumberOfMemoizedModelVersions; }
 
   Poincare::Preferences::AngleUnit * m_angleUnitVersion;
   int * m_indexFunctionSelectedByCursor;

apps/shared/function_store.cpp

@@ -6,11 +6,4 @@ uint32_t FunctionStore::storeChecksum() {
   return Ion::Storage::sharedStorage()->checksum();
 }
 
-uint32_t FunctionStore::storeChecksumAtIndex(int i) {
-  if (numberOfActiveFunctions() <= i) {
-    return 0;
-  }
-  return activeRecordAtIndex(i).checksum();
-}
-
 }

apps/shared/function_store.h

@@ -13,7 +13,6 @@ class FunctionStore : public ExpressionModelStore {
 public:
   FunctionStore() : ExpressionModelStore() {}
   uint32_t storeChecksum();
-  uint32_t storeChecksumAtIndex(int i);
   int numberOfActiveFunctions() const {
     return numberOfModelsSatisfyingTest(&isFunctionActive, nullptr);
   }

apps/shared/interactive_curve_view_controller.cpp

@@ -8,11 +8,9 @@ using namespace Poincare;
 
 namespace Shared {
 
-InteractiveCurveViewController::InteractiveCurveViewController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, uint32_t * modelVersion, uint32_t * previousModelsVersions, uint32_t * rangeVersion) :
+InteractiveCurveViewController::InteractiveCurveViewController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, uint32_t * rangeVersion) :
   SimpleInteractiveCurveViewController(parentResponder, cursor),
   ButtonRowDelegate(header, nullptr),
-  m_modelVersion(modelVersion),
-  m_previousModelsVersions(previousModelsVersions),
   m_rangeVersion(rangeVersion),
   m_rangeParameterController(this, inputEventHandlerDelegate, interactiveRange),
   m_zoomParameterController(this, interactiveRange, curveView),
@@ -135,58 +133,13 @@ Responder * InteractiveCurveViewController::defaultController() {
   return tabController();
 }
 
-bool InteractiveCurveViewController::previousModelsWereAllDeleted() {
-  bool result = true;
-  const int modelsCount = numberOfCurves();
-  const int memoizationCount = numberOfMemoizedVersions();
-
-  // Look for a current model that is the same as in the previous version
-  for (int i = 0; i < modelsCount; i++) {
-    uint32_t currentVersion = modelVersionAtIndex(i);
-    for (int j = 0; j < memoizationCount; j++) {
-      uint32_t * previousVersion = m_previousModelsVersions + j;
-      if (currentVersion == *previousVersion) {
-        result = false;
-        break;
-      }
-    }
-    if (!result) {
-      break;
-    }
-  }
-
-  // Update the memoization
-  for (int i = 0; i < memoizationCount; i++) {
-    uint32_t * previousVersion = m_previousModelsVersions + i;
-    uint32_t newVersion = modelVersionAtIndex(i);
-    if (*previousVersion != newVersion) {
-      *previousVersion = newVersion;
-    }
-  }
-  return result;
-}
-
 void InteractiveCurveViewController::viewWillAppear() {
   SimpleInteractiveCurveViewController::viewWillAppear();
-  uint32_t newModelVersion = modelVersion();
-  if (*m_modelVersion != newModelVersion) {
-    // Put previousModelsWereAllDeleted first to update the model versions
-    if (previousModelsWereAllDeleted() || *m_modelVersion == 0 || numberOfCurves() == 1 || shouldSetDefaultOnModelChange()) {
-      interactiveCurveViewRange()->setDefault();
-    }
-    *m_modelVersion = newModelVersion;
-    didChangeRange(interactiveCurveViewRange());
-    /* Warning: init cursor parameter before reloading banner view. Indeed,
-     * reloading banner view needs an updated cursor to load the right data. */
-    initCursorParameters();
-  }
-  uint32_t newRangeVersion = rangeVersion();
-  if (*m_rangeVersion != newRangeVersion) {
-    *m_rangeVersion = newRangeVersion;
-    if (!isCursorVisible()) {
-      initCursorParameters();
-    }
-  }
+
+  /* Warning: init cursor parameter before reloading banner view. Indeed,
+   * reloading banner view needs an updated cursor to load the right data. */
+  initCursorParameters();
+
   curveView()->setOkView(&m_okView);
   if (!curveView()->isMainViewSelected()) {
     curveView()->selectMainView(true);

apps/shared/interactive_curve_view_controller.h

@@ -12,7 +12,7 @@ namespace Shared {
 
 class InteractiveCurveViewController : public SimpleInteractiveCurveViewController, public InteractiveCurveViewRangeDelegate, public ButtonRowDelegate, public AlternateEmptyViewDefaultDelegate {
 public:
-  InteractiveCurveViewController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, uint32_t * modelVersion, uint32_t * previousModelsVersions, uint32_t * rangeVersion);
+  InteractiveCurveViewController(Responder * parentResponder, InputEventHandlerDelegate * inputEventHandlerDelegate, ButtonRowController * header, InteractiveCurveViewRange * interactiveRange, CurveView * curveView, CurveViewCursor * cursor, uint32_t * rangeVersion);
 
   const char * title() override;
   bool handleEvent(Ion::Events::Event event) override;
@@ -27,8 +27,6 @@ public:
 
   Responder * defaultController() override;
 
-  bool previousModelsWereAllDeleted();
-
   void viewWillAppear() override;
   void viewDidDisappear() override;
   void willExitResponderChain(Responder * nextFirstResponder) override;
@@ -40,8 +38,6 @@ protected:
   virtual StackViewController * stackController() const;
   virtual void initCursorParameters() = 0;
   virtual bool moveCursorVertically(int direction) = 0;
-  virtual uint32_t modelVersion() = 0;
-  virtual uint32_t modelVersionAtIndex(int i) = 0;
   virtual uint32_t rangeVersion() = 0;
   bool isCursorVisible();
 
@@ -70,10 +66,6 @@ private:
   // InteractiveCurveViewRangeDelegate
   float addMargin(float x, float range, bool isVertical, bool isMin) override;
 
-  virtual bool shouldSetDefaultOnModelChange() const { return false; }
-  virtual size_t numberOfMemoizedVersions() const = 0;
-  uint32_t * m_modelVersion;
-  uint32_t * m_previousModelsVersions;
   uint32_t * m_rangeVersion;
   RangeParameterController m_rangeParameterController;
   ZoomParameterController m_zoomParameterController;