From 9c2fc84cd0f3dedfd89ab2b96c9a5ccefe8f1a90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Fri, 14 Jun 2019 09:27:23 -0400 Subject: [PATCH] [code] Fix 'use address after scope' issue We used an array that was out of scope in PythonToolbox. --- apps/code/python_toolbox.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/code/python_toolbox.cpp b/apps/code/python_toolbox.cpp index fa14d93dc..a002b7f8a 100644 --- a/apps/code/python_toolbox.cpp +++ b/apps/code/python_toolbox.cpp @@ -361,9 +361,10 @@ bool PythonToolbox::selectLeaf(int selectedRow) { m_selectableTableView.deselectTable(); ToolboxMessageTree * node = (ToolboxMessageTree *)m_messageTreeModel->children(selectedRow); const char * editedText = I18n::translate(node->insertedText()); + // strippedEditedText array needs to be in the same scope as editedText + char strippedEditedText[k_maxMessageSize]; if (node->stripInsertedText()) { int strippedEditedTextMaxLength = strlen(editedText)+1; - char strippedEditedText[k_maxMessageSize]; assert(strippedEditedTextMaxLength <= k_maxMessageSize); Shared::ToolboxHelpers::TextToInsertForCommandMessage(node->insertedText(), strippedEditedText, strippedEditedTextMaxLength, true); editedText = strippedEditedText;