UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps/shared/expression_model] Add TODOs for later

Browse Source
This commit is contained in:
Ruben Dashyan
2019-09-26 17:27:27 +02:00
committed by Léa Saviot
parent c3cf5c1ef4
commit a3053acac4
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
apps/shared/expression_model.cpp
View File

@@ -41,6 +41,26 @@ bool ExpressionModel::isCircularlyDefined(const Storage::Record * record, Poinca
}
Expression ExpressionModel::expressionReduced(const Storage::Record * record, Poincare::Context * context) const {
/* TODO
* By calling isCircularlyDefined and then Simplify, the expression tree is
* browsed twice. Note that Simplify does ALMOST the job of
* isCircularlyDefined, since Simplify reduces the expression, replaces the
* symbols it encounters (see SymbolAbstract::Expand). isCircularlyDefined
* should probably be removed. The difficulty relies in the ambiguous
* conventions about the values returned or set when a symbol has no proper
* expression: for example,
* - GlobalContext::expressionForSymbolAbstract returns an uninitialized
* expression,
* - so do Expression::ExpressionWithoutSymbols and SymbolAbstract::Expand,
* - Expression::deepReplaceReplaceableSymbols leaves unchanged the symbols,
* whose expression is uninitialized, but returns Undefined if the
* expression for a symbol contains the symbol itself,
* - Symbol::shallowReduce and Function::shallowReduce return Undefined or
* the expression unaltered according to symbolic-computation setting,
* - expressionReduced returns Undefined if the expression
* isCircularlyDefined but leaves the expression unchanged if Simplify
* returns an uninitialized expression...
*/
if (m_expression.isUninitialized()) {
assert(record->fullName() != nullptr);
if (isCircularlyDefined(record, context)) {
@@ -61,6 +81,13 @@ Expression ExpressionModel::expressionClone(const Storage::Record * record) cons
assert(record->fullName() != nullptr);
/* A new Expression has to be created at each call (because it might be tempered with after calling) */
return Expression::ExpressionFromAddress(expressionAddress(record), expressionSize(record));
/* TODO
* The substitution of UCodePointUnknown back and forth is done in the
* methods text, setContent (through BuildExpressionFromText), layout and
* also in GlobalContext::expressionForSymbolAbstract and
* GlobalContext::setExpressionForSymbolAbstract. When getting the
* expression, the substitutions may probably be gathered here.
*/
}
Layout ExpressionModel::layout(const Storage::Record * record, CodePoint symbol) const {