diff --git a/ion/Makefile b/ion/Makefile index 811326c28..459b8cbeb 100644 --- a/ion/Makefile +++ b/ion/Makefile @@ -2,9 +2,8 @@ SFLAGS += -Iion/include -DKD_CONFIG_H=1 include ion/src/$(PLATFORM)/Makefile objs += $(addprefix ion/src/shared/, \ - c.o \ events.o \ - log_integer.o \ + log_uint32.o \ ) tests += $(addprefix ion/test/,\ diff --git a/ion/include/ion/c.h b/ion/include/ion/c.h deleted file mode 100644 index d28430ec6..000000000 --- a/ion/include/ion/c.h +++ /dev/null @@ -1,17 +0,0 @@ -#ifndef ION_C_H -#define ION_C_H - -#include - -#ifdef __cplusplus -extern "C" { -#endif - -void ion_log_print_string(const char * message); -void ion_log_print_integer(uint32_t integer); - -#ifdef __cplusplus -} -#endif - -#endif diff --git a/ion/include/ion/log.h b/ion/include/ion/log.h index ee5c4de1c..c6f1ace0e 100644 --- a/ion/include/ion/log.h +++ b/ion/include/ion/log.h @@ -1,15 +1,28 @@ #ifndef ION_LOG_H #define ION_LOG_H +// Ion offers a C-compatible logging API + #include -namespace Ion { -namespace Log { +#ifdef DEBUG -void print(const char * message); -void print(uint32_t number); +#ifdef __cplusplus +extern "C" { +#endif +void ion_log_string(const char * message); +void ion_log_uint32(uint32_t integer); + +#ifdef __cplusplus } -} +#endif + +#else + +#define ion_log_print_string(m) ((void)0) +#define ion_log_print_uint32(i) ((void)0) + +#endif #endif diff --git a/ion/src/blackbox/Makefile b/ion/src/blackbox/Makefile index 0e2ba8f2f..2a2f48899 100644 --- a/ion/src/blackbox/Makefile +++ b/ion/src/blackbox/Makefile @@ -4,7 +4,6 @@ objs += $(addprefix ion/src/shared/, \ events.o \ events_stdin.o \ log_printf.o \ - log_integer.o \ power.o \ ) diff --git a/ion/src/device/log.cpp b/ion/src/device/log.cpp index 2b6a25a99..25ee1e7e2 100644 --- a/ion/src/device/log.cpp +++ b/ion/src/device/log.cpp @@ -5,7 +5,7 @@ // This is achieved by writing to the ITM register, which is sent through the // Cortex Debug bus -void Ion::Log::print(const char * message) { +void ion_log_string(const char * message) { char character = 0; while ((character = *message++) != 0) { if (ITM.TER()->get(0)) { diff --git a/ion/src/shared/c.cpp b/ion/src/shared/c.cpp deleted file mode 100644 index 12feeab32..000000000 --- a/ion/src/shared/c.cpp +++ /dev/null @@ -1,10 +0,0 @@ -#include -#include - -void ion_log_print_integer(uint32_t i) { - Ion::Log::print(i); -} - -void ion_log_print_string(const char * message) { - Ion::Log::print(message); -} diff --git a/ion/src/shared/log_printf.cpp b/ion/src/shared/log_printf.cpp index f30643ea8..9459269f7 100644 --- a/ion/src/shared/log_printf.cpp +++ b/ion/src/shared/log_printf.cpp @@ -1,7 +1,7 @@ #include #include -void Ion::Log::print(const char * message) { +void ion_log_string(const char * message) { printf("%s", message); fflush(stdout); } diff --git a/ion/src/shared/log_integer.cpp b/ion/src/shared/log_uint32.cpp similarity index 68% rename from ion/src/shared/log_integer.cpp rename to ion/src/shared/log_uint32.cpp index a54278146..c25241d95 100644 --- a/ion/src/shared/log_integer.cpp +++ b/ion/src/shared/log_uint32.cpp @@ -1,7 +1,8 @@ #include -#include -void Ion::Log::print(uint32_t i) { +#ifdef DEBUG + +void ion_log_uint32(uint32_t i) { char buffer[9]; for (int j=0; j<8; j++) { uint8_t v = (i & 0xF); @@ -9,5 +10,7 @@ void Ion::Log::print(uint32_t i) { i = i >> 4; } buffer[8] = 0; - print(buffer); + ion_log_string(buffer); } + +#endif diff --git a/liba/src/malloc.c b/liba/src/malloc.c index cb26a78df..433624040 100644 --- a/liba/src/malloc.c +++ b/liba/src/malloc.c @@ -3,7 +3,7 @@ #include #if LIBA_LOG_DYNAMIC_MEMORY -#include +#include #endif extern char _heap_start;