From bb83f057fe9db6347bcc1850d9504db1010d0452 Mon Sep 17 00:00:00 2001
From: Ruben Dashyan <ruben.dashyan@numworks.com>
Date: Tue, 12 Nov 2019 15:25:57 +0100
Subject: [PATCH] [apps/shared/values_controller] Simplify didChangeCell

Shift by m_firstMemoizedRow earlier.
---
 apps/shared/values_controller.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/apps/shared/values_controller.cpp b/apps/shared/values_controller.cpp
index 1b34ac3f4..ec0a2c4bd 100644
--- a/apps/shared/values_controller.cpp
+++ b/apps/shared/values_controller.cpp
@@ -237,14 +237,13 @@ void ValuesController::didChangeCell(int column, int row) {
   // the first row is never reloaded as it corresponds to title row
   assert(row > 0);
   // Conversion of coordinates from absolute table to values table
-  int valuesRow = valuesRowForAbsoluteRow(row);
-  if (m_firstMemoizedRow > valuesRow || valuesRow >= m_firstMemoizedRow + k_maxNumberOfDisplayableRows) {
+  int memoizedRow = valuesRowForAbsoluteRow(row) - m_firstMemoizedRow;
+  if (0 > memoizedRow || memoizedRow >= k_maxNumberOfDisplayableRows) {
     // The changed row is out of the memoized table
     return;
   }
 
   // Update the memoization of rows linked to the changed cell
-  int memoizedRow = valuesRow - m_firstMemoizedRow;
   int nbOfMemoizedColumns = numberOfMemoizedColumn();
   for (int i = column+1; i < column+numberOfColumnsForAbscissaColumn(column); i++) {
     int memoizedI = valuesColumnForAbsoluteColumn(i) - m_firstMemoizedColumn;