UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-18 21:30:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps/code] Remove more TODOs

Browse Source
This commit is contained in:
Léa Saviot
2020-04-30 17:14:12 +02:00
committed by Émilie Feral
parent 8142e1d344
commit e4aac3f9c6
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/code/python_text_area.cpp
View File

@@ -296,7 +296,6 @@ bool PythonTextArea::handleEvent(Ion::Events::Event event) {
} else if(event == Ion::Events::Up } else if(event == Ion::Events::Up
|| event == Ion::Events::Down) || event == Ion::Events::Down)
{ {
//TODO LEA handle only one suggestion in var box.
cycleAutocompletion(event == Ion::Events::Down); cycleAutocompletion(event == Ion::Events::Down);
return true; return true;
} else { } else {
@@ -343,9 +342,7 @@ void PythonTextArea::removeAutocompletionText() {
const char * autocompleteStart = m_contentView.cursorLocation(); const char * autocompleteStart = m_contentView.cursorLocation();
const char * autocompleteEnd = m_contentView.autocompletionEnd(); const char * autocompleteEnd = m_contentView.autocompletionEnd();
assert(autocompleteEnd != nullptr && autocompleteEnd > autocompleteStart); assert(autocompleteEnd != nullptr && autocompleteEnd > autocompleteStart);
//TODO LEA if (autocompleteEnd > autocompleteStart) {
m_contentView.removeText(autocompleteStart, autocompleteEnd); m_contentView.removeText(autocompleteStart, autocompleteEnd);
//TODO LEA }
} }
void PythonTextArea::addAutocompletion() { void PythonTextArea::addAutocompletion() {

4
apps/code/script_node.h
View File

@@ -21,7 +21,7 @@ public:
{} {}
Type type() const { return m_type; } Type type() const { return m_type; }
const char * name() const { return m_name; } const char * name() const { return m_name; }
int nameLength() const { return m_nameLength; } int nameLength() const { return static_cast<int>(m_nameLength); }
const char * nodeSourceName() const { return m_nodeSourceName; } const char * nodeSourceName() const { return m_nodeSourceName; }
const char * description() const { return m_description; } const char * description() const { return m_description; }
private: private:
@@ -29,7 +29,7 @@ private:
const char * m_name; const char * m_name;
const char * m_nodeSourceName; const char * m_nodeSourceName;
const char * m_description; const char * m_description;
int m_nameLength; // TODO LEA smaller type ? size_t m_nameLength;
}; };
} }

2
apps/code/script_node_cell.cpp
View File

@@ -28,7 +28,7 @@ void ScriptNodeCell::ScriptNodeView::drawRect(KDContext * ctx, KDRect rect) cons
} }
/* If it exists, draw the source name. If it did not fit, we would have put /* If it exists, draw the source name. If it did not fit, we would have put
* nullptr at the node creation. TODO LEA */ * nullptr at the node creation. */
const char * sourceName = m_scriptNode->nodeSourceName(); const char * sourceName = m_scriptNode->nodeSourceName();
if (sourceName != nullptr) { if (sourceName != nullptr) {
KDSize sourceNameSize = k_font->stringSize(sourceName); KDSize sourceNameSize = k_font->stringSize(sourceName);