From f275b91c8cf040489122ee72b489f855289be95c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Wed, 10 Apr 2019 19:11:34 +0200 Subject: [PATCH] [ion] WakeUp: fix comments --- ion/src/device/shared/drivers/wakeup.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ion/src/device/shared/drivers/wakeup.cpp b/ion/src/device/shared/drivers/wakeup.cpp index fb827baca..b8d045845 100644 --- a/ion/src/device/shared/drivers/wakeup.cpp +++ b/ion/src/device/shared/drivers/wakeup.cpp @@ -18,8 +18,10 @@ void onChargingEvent() { /* Warning: pins with the same number in different groups cannot be set as * source input for EXTI at the same time. Here, EXTICR1 register is filled - * between position 0-3 (charging pin = 0) with - * 0000 (ChargingGPIO = group A). */ + * between: + * - N0100: position 0-3 (charging pin = 0) with 0000 (ChargingGPIO = group A) + * - N0101: position 12-15 (charging pin = 3) with 0100 (ChargingGPIO = group E) + */ SYSCFG.EXTICR1()->setEXTI(Battery::Config::ChargingPin.pin(), Battery::Config::ChargingPin.group()); EXTI.EMR()->set(Battery::Config::ChargingPin.pin(), true); @@ -54,8 +56,9 @@ void onPowerKeyDown() { Keyboard::Config::ColumnGPIO.MODER()->setMode(columnPin, GPIO::MODER::Mode::Input); Keyboard::Config::ColumnGPIO.PUPDR()->setPull(columnPin, GPIO::PUPDR::Pull::Up); - /* Here, EXTICR1 register is filled between position 4-7 (column pin = 1) with - * 0010 (ColumnGPIO = group C). */ + /* Here, EXTICR1 register is filled between: + * - N0100: position 4-7 (column pin = 1) with 0010 (ColumnGPIO = group C) + * - N0101: position 8-11 (column pin = 2) with 0010 (ColumnGPIO = group C). */ SYSCFG.EXTICR1()->setEXTI(columnPin, Keyboard::Config::ColumnGPIO);