From f5e7c016e8d1342cfe44613ea0d0e2714ced4031 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89milie=20Feral?= Date: Tue, 17 Dec 2019 16:58:45 +0100 Subject: [PATCH] [apps] GlobalPreferences: avoid multiple calls to examMode() --- apps/global_preferences.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/global_preferences.cpp b/apps/global_preferences.cpp index 52572a469..7a0763e49 100644 --- a/apps/global_preferences.cpp +++ b/apps/global_preferences.cpp @@ -14,11 +14,12 @@ GlobalPreferences::ExamMode GlobalPreferences::examMode() const { } void GlobalPreferences::setExamMode(ExamMode mode) { - if (examMode() == mode) { + ExamMode currentMode = examMode(); + if (currentMode == mode) { return; } assert(mode != ExamMode::Unknown); - int8_t deltaMode = (int8_t)mode - (int8_t)examMode(); + int8_t deltaMode = (int8_t)mode - (int8_t)currentMode; deltaMode = deltaMode < 0 ? deltaMode + 3 : deltaMode; assert(deltaMode > 0); Ion::ExamMode::IncrementExamMode(deltaMode);