Ruben Dashyan
0943406263
Fix HistoryViewCell and ScrollableExactApproximateExxpressionsCell margins issue
...
Remove all margins from those cells.
Rather add margins to their respective subviews:
- ScrollableExpressionView
- ScrollableExactApproximateExpressionsView.
As a notable consequence, the distance in HistoryViewCell between its
subviews becomes 10 instead of 5.
In passing, replace
- Metric::HistoryHorizontalMargin = 10
- ScrollableExactApproximateExpressionsView::k_digitHorizontalMargin = 10
- HistoryViewCell::k_digitVerticalMargin = 5
- ScrollableExactApproximateExpressionsCell::k_margin = 5
by
- Metric::CommonSmallMargin = 5
- Metric::CommonLargeMargin = 10.
2019-02-18 16:49:58 +01:00
Ruben Dashyan
98e00404b8
[apps/calculation] Enable arrow scrolling indicators and add horizontal margin
2019-02-18 16:49:58 +01:00
Ruben Dashyan
da0d42ca3b
[apps/calculation/history_view_cell] Fix background colors
...
Set m_inputView's m_expressionView's background color
2019-02-18 16:49:58 +01:00
Ruben Dashyan
7a977f5689
[apps/calculation] Remove redundancy
...
In HistoryController::willDisplayCellForIndex, both setCalculation and
reloadCell end up calling ScrollableExpressionView::layoutSubviews.
Indeed, setCalculation calls setLayout over m_inputView, which in turn
calls layoutSubviews. It is logical to remove the first occurence.
2019-02-18 16:49:58 +01:00
Ruben Dashyan
08e8bf0eeb
[escher] Implement ScrollView::minimalSizeForOptimalDisplay including margins
...
Remove from derived classes:
- apps/calculation/scrollable_expression_view
- apps/code/consol_line_cell
- apps/shared/scrollable_exact_approximate_expressions_view
- escher/layout_field
- escher/table_view
- escher/text_field
2019-02-18 16:49:58 +01:00
Émilie Feral
365b145cf3
[poincare] Change names: LayoutReference-->Layout
2018-09-18 16:29:44 +02:00
Émilie Feral
616e4c0bcc
[poincare] Change name: LayoutRef --> LayoutReference
2018-09-14 16:57:12 +02:00
Léa Saviot
f579e95815
[poincare] Start removing ExpressionLayout
2018-07-03 17:33:06 +02:00
Léa Saviot
4de2ae5353
[poincare] Fix virtualty of ScrollView::setBackgroundColor and TopMargin
...
Change-Id: Id15d2b233b0a0f11435ab8f41a142eeca4fcec05
2018-05-08 17:52:54 +02:00
Léa Saviot
4ad3adaab2
[apps/escher] Changed setExpression to setExpressionLayout.
...
Change-Id: I095a12868fd7eaf8d4eb2408617941a86f43e1ee
2018-01-15 11:58:01 +01:00
Émilie Feral
ee51729eba
[escher] Move from table view to scroll view the method a update the
...
scroll to the size of the content view
Change-Id: I2c4aa457425bf5a8a484aecc061ae27453e9aabb
2017-08-18 13:34:29 +02:00
Émilie Feral
96733dbbdc
[apps] Rule of 5 (3)
...
Change-Id: Ia85b23a09e9debd62b4f3590463a4f16454ef4b7
2017-05-09 14:33:53 +02:00
Émilie Feral
0517066cc0
[escher] Extrude scroll view model to its delegate
...
Change-Id: If863de63f5f77edb5e2905633067e03aecdd8937
2017-05-03 10:22:01 +02:00
Émilie Feral
8f1d37c28c
[escher] Add a cursor to text fields
...
Change-Id: Ib4a80a3c6d4b5d76cb56645275e8ecc6d69528ca
2017-03-08 15:42:14 +01:00
Émilie Feral
21a6ae216a
[escher] Create a class scrollable view
...
Change-Id: I2c588da1f6fd6b1bde878f85c02d0e4dffd04f52
2017-03-07 13:28:26 +01:00
Émilie Feral
e65b07286d
[escher] [apps] Get rid of magic numbers
...
Change-Id: Iad192d24324dda37b3d739830cc8ead7a032e22f
2017-02-20 10:54:03 +01:00
Émilie Feral
69e46f4958
[poincare] Namespace Poincare
...
Change-Id: I51a84fa7978ba16f128cfe1d32c390970f2037e8
2017-02-13 17:15:06 +01:00
Émilie Feral
172528f49f
[apps/calculation] Change names: PrettyPrintView -->
...
ScrollableExpressionView and make result View an scrollable expression
view
Change-Id: I9ac85671bcb4fdbeda0e5dbc6788dc7eb93b7343
2016-12-09 11:01:44 +01:00