Commit Graph

66 Commits

Author SHA1 Message Date
Ruben Dashyan
0943406263 Fix HistoryViewCell and ScrollableExactApproximateExxpressionsCell margins issue
Remove all margins from those cells.
Rather add margins to their respective subviews:
 - ScrollableExpressionView
 - ScrollableExactApproximateExpressionsView.

As a notable consequence, the distance in HistoryViewCell between its
subviews becomes 10 instead of 5.

In passing, replace
 - Metric::HistoryHorizontalMargin = 10
 - ScrollableExactApproximateExpressionsView::k_digitHorizontalMargin = 10
 - HistoryViewCell::k_digitVerticalMargin = 5
 - ScrollableExactApproximateExpressionsCell::k_margin = 5
by
 - Metric::CommonSmallMargin = 5
 - Metric::CommonLargeMargin = 10.
2019-02-18 16:49:58 +01:00
Émilie Feral
f7193602ef [calculation] Bug in the subview selected with heigh cells
In SelectableTableView::selectCellAtLocation, we call 'tableViewDidChangeSelection'
before scrolling. Therefore, the cell with updated with the right selected subview
is not the one drawn... To solve this issue, we keep the selectedSubview ('model')
 in the HistoryController instead of in the limited-lifespan view.
2018-12-06 14:52:23 +01:00
Léa Saviot
f7913fb744 [apps/calc] Fix history cell output copy 2018-11-23 12:04:06 +01:00
Émilie Feral
27064d00f7 [calculation] Get rid of DynamicViewController in HistoryController 2018-09-10 12:59:36 +02:00
Émilie Feral
c24e2726fa [escher][apps] Get rid of duplicate overriden methods:
cumulatedHeightFromIndex, indexFromCumulatedHeight
2018-06-12 10:27:23 +02:00
Émilie Feral
ac9da8d559 [escher] Handle copy/cut event on Expression in selectable table view 2018-06-07 14:46:14 +02:00
Émilie Feral
24c9549866 [escher] Handle copy/cut event on selectable table view 2018-06-07 14:46:14 +02:00
Émilie Feral
cfb891d7bd [shared] Move OutputExpressionView & ScrollableOuputExpression view to shared/ with new name:
ScrollableExactApproximateExpressionsView (for future implementation of solver
solution page)
2018-06-07 13:46:18 +02:00
Émilie Feral
1108ef21db [calculation] Do not memoize the expression layouts but the expressions
final height to avoid overflowing the heap. The expression layouts are
kept in the cell which are fewer then the number of calculations
2018-05-16 18:36:45 +02:00
Émilie Feral
1d7bd2b70a [calculation] Change method name: shouldDisplayApproximateOutput --> shouldOnlyDisplayApproximateOutput 2018-05-15 11:33:28 +02:00
Émilie Feral
17fc7998a2 [apps] Calculation: Ans is exact only when the expression hold is exact 2018-01-16 15:17:16 +01:00
Émilie Feral
89485104b8 [apps] In calculation, fix history table row height
Change-Id: Ia0ee485b80d6f4db81f480d0e3e8f91b73c912a2
2017-11-24 17:13:21 +01:00
Émilie Feral
b2d6c2e305 [apps] In calculation, avoid blinking when changing selection
Change-Id: I8b94362183e1aed0d87cfdfa39b3f67ccbbd8b42
2017-11-21 17:37:25 +01:00
Émilie Feral
65722ff875 [apps] Fix bug when computing the history cell height in Calculation
Change-Id: Ic45f3da26a47b189ef6050d68c25f27c9a1f4bb7
2017-11-21 17:37:25 +01:00
Émilie Feral
5fd8fda4b1 [calculation] Display exact and approximate results
Change-Id: Id5fe5b5db464c45f09bd1a1285def95e738a78c7
2017-11-21 17:37:25 +01:00
Émilie Feral
319955424b [escher] In table view, use scrollToContentRect instead of recomputing
everything

Change-Id: Idb3ec8218386b03bc34d08fcd888d1a671ea98f9
2017-08-17 16:21:20 +02:00
Émilie Feral
d4f3fc6b5c [apps/calculation] Insert text rather than overwrite when selecting a
history cell

Change-Id: Ie2cbe92a14a64caa3d1b4eabce6dc6de4baaaa34
2017-05-31 11:54:54 +02:00
Émilie Feral
1d0658141a [apps/calculations] Fix selection error
Change-Id: Iee7c65e1079acb729a490d7dd92a7be04789dcbe
2017-05-30 09:53:47 +02:00
Émilie Feral
af4d6b6e81 [escher] Divide class selectable table view delegate in 2: selectable
table view data source & selectable table view delegate

Change-Id: I90fbd61e271db3754c13bd0069b95c2026de6814
2017-05-18 14:16:41 +02:00
Émilie Feral
71284311bb [escher] [apps] Implement app snapshot
Change-Id: I24d7eed7cef964af8be1c85222e758c297dc0da1
2017-05-18 14:16:41 +02:00
Émilie Feral
62c93e49a6 [apps] AppsContainer does not own the apps but a pointer to the apps
Change-Id: I9b6787be2cd143b52fd8dd60f3528fed2f74e4bb
2017-05-03 15:32:54 +02:00
Émilie Feral
70fc734f7b [escher] Change dynamic view controller paradigm
Change-Id: I57fd41c9b9ad8a1e8b684b97fdf80ddffd71881d
2017-05-03 14:22:51 +02:00
Émilie Feral
40aa86ccb7 [apps/calculation] EXE and OK have same behaviour on history controller
Change-Id: I4fed572db45e4604a1b44e5343f14b50db8cfcc6
2017-05-03 14:22:50 +02:00
Émilie Feral
0517066cc0 [escher] Extrude scroll view model to its delegate
Change-Id: If863de63f5f77edb5e2905633067e03aecdd8937
2017-05-03 10:22:01 +02:00
Émilie Feral
3f98061a4c [escher] Extrude the model in selectable table view controller to its
delegate

Change-Id: I4d49e0098d501e1419f7b216e828b13efbf74f81
2017-05-03 10:22:01 +02:00
Émilie Feral
b4f0256ad4 [apps/calculation] Implement copy paste
Change-Id: Id3447c4d6683b7b7349ed5669b717ad9befe5dc9
2017-04-25 16:59:35 +02:00
Émilie Feral
fa5d03bbc9 [apps/calculation] Clean
Change-Id: I8867d19caf17417f45efda9dc1a1188a97eedd64
2017-04-25 14:40:59 +02:00
Émilie Feral
2b5e1c31bf [apps/calculation] Deselect table when deleting all rows
Change-Id: Ia0f7f931669bdc2664ff99e3a9694652783812bd
2017-04-24 17:36:32 +02:00
Émilie Feral
80873cf025 [apps/calculation] Make calculation views dynamically allocated
Change-Id: I45946e46203bd8dde21793ee2395c76dc15db06c
2017-04-20 12:12:04 +02:00
Émilie Feral
85b27c372d [apps/calculation] Fix error: scroll when copying a history line
Change-Id: I6120c22afd63abe6ac5bf4e264ad7fcc712fe291
2017-03-29 15:04:37 +02:00
Émilie Feral
adc80cd71b [apps][escher] I18n
Change-Id: I4d6f40155a8a182184af9ef2a583d0469196ffd5
2017-03-16 15:12:12 +01:00
Émilie Feral
a019289a6a [poincare] Implement complex format
Change-Id: I98731b356cce0ae3107fd0a660697241210692ae
2017-03-07 15:53:05 +01:00
Émilie Feral
695c8812bb [apps] Handle back event
Change-Id: I5d4502fa4ba6cc55a7bf1da90687a129ef322d34
2017-03-07 14:34:47 +01:00
Émilie Feral
2e16365100 [escher] Reorganize all cells'name and factorize their layouts
Change-Id: I69900ee98ff6a6868f96d70a0e335a589ef16c3f
2017-02-20 10:54:02 +01:00
Émilie Feral
e5e9f7cc41 [poincare][apps] Make preferences a const object accessible from
anywhere (poincare and apps)

Change-Id: I49cc6bf940d1efeb6b153daac949ffcb23999a8d
2017-02-20 09:39:24 +01:00
Émilie Feral
15a736c855 [apps/shared] Avoid container casting when possible
Change-Id: I646e605c88ad577ebd9102032aad77ff8eae6ad7
2017-02-17 16:35:07 +01:00
Émilie Feral
47cec5e72b [apps] Put the method preference in container instead of in every app
Change-Id: Ib390952a6559aa847c99e3ca74c4f6995a07e909
2017-02-02 10:29:07 +01:00
Émilie Feral
b37688745e [apps/calculation] Create input and output layout according to display
mode set in preference

Change-Id: If161958b2fcdad802fda5f8e0c44f8a5fc9d9ef1
2017-02-02 10:28:59 +01:00
Émilie Feral
2ae41a3d46 [apps/calculation] Enable to recompute calculation in history
Change-Id: I6ad431ac4bd712acb48c7dc609846112a7fcb3e4
2017-01-30 16:11:48 +01:00
Émilie Feral
7af3979d3b [poincare] Change Context API
Change-Id: I2818866fb41bf73c39396fbd85600e586a79065c
2016-12-15 13:51:41 +01:00
Émilie Feral
8c284ba34f [escher][apps] CHange textField API
Change-Id: I766d153b7f7429473f297707a08358051123accc
2016-12-15 13:51:40 +01:00
Émilie Feral
172528f49f [apps/calculation] Change names: PrettyPrintView -->
ScrollableExpressionView and make result View an scrollable expression
view

Change-Id: I9ac85671bcb4fdbeda0e5dbc6788dc7eb93b7343
2016-12-09 11:01:44 +01:00
Émilie Feral
e1f808e7da [apps/calculation] Change names: expression->input, evaluation->output
Change-Id: I9d65a9fc7d1b7132ae3aaa8a86e4511286b7e3da
2016-12-09 11:01:44 +01:00
Émilie Feral
69e381d736 [poincare] Redesign the text method of expression to avoid keeping a
buffer in all expressions

Change-Id: I2ca33be09a525adf429854e651beaa75e5605d7a
2016-12-09 11:01:43 +01:00
Émilie Feral
0448278e36 [calculation] Make the results of calculation expressions
Change-Id: I9eb685b21944cfc6cc346a42d442f064ae5938dd
2016-12-08 15:21:52 +01:00
Romain Goyet
b87f06e3a2 [ion] Update the Event model
Change-Id: I41a53caeb7dd8a15e7934f49675f6a53be8fe7be
2016-11-10 17:29:48 +01:00
Émilie Feral
f5272cb0cf [apps/calculation] Evaluate calculations in the context including ANS
Change-Id: I9442885551d928d2c1a32bae1324eb6c45af3c94
2016-11-04 16:49:12 +01:00
Émilie Feral
2f45578886 [apps/calculation] Handle calculation to heigh to be fully displayed in
the screen

Change-Id: I182f0c76d911e6686223a22be2a6ddb561b287ec
2016-11-04 14:47:07 +01:00
Émilie Feral
13d494f1b7 [apps/calculation] Handle clearing all history
Change-Id: Ib18a0a25b9124d1ca9749d428404e0f1577c6b16
2016-11-04 11:08:15 +01:00
Émilie Feral
622ac2f2ce [apps/calculation] Handle delete a history cell
Change-Id: Ia4c5526ce9831098f9b291c674160018e05be916
2016-11-04 11:08:15 +01:00