Commit Graph

7312 Commits

Author SHA1 Message Date
Léa Saviot
b3d1f8975c [poincare] cursorLeftOf, RightOf, etc., use a cursor object, not pointer
Change-Id: If9a148e663cd7a18a303adc9175aab953d825945
2018-04-26 10:21:26 +02:00
Léa Saviot
ce81481922 [apps/calculation] Do not reload if the ELView is already maximal
Change-Id: Id21cc71de7d5d83a30c6b7beea3c71108bed7197
2018-04-25 18:08:35 +02:00
Léa Saviot
cff95c2ac1 [escher/poincare] Fix non ELField size change.
When adding a big layout (e.g. SumLayout), the inputView did not change
it size (in calculation and in Saquence for instance).

Change-Id: Ic8604a4085c29e69d2aecc7ac8a88ca9889f34f1
2018-04-25 18:00:53 +02:00
Léa Saviot
47cf7d3f35 [poincare] Fix missing return statement
Change-Id: I56aa9bff457d150efc7c451d57155c9e0db8cec4
2018-04-25 18:00:28 +02:00
Léa Saviot
728537c7ff [escher/poincare] Remove ELCursor::pointedELEquivalentChild
Change-Id: Iac459394b8743030243dc9e7e682c427f265a817
2018-04-25 17:10:40 +02:00
Léa Saviot
5901021152 [poincare] Fix ExpressionLayoutCursor::baseForNewPowerLayout
Change-Id: I955479d62522d96a8fa18a9575f843107ff0e2ea
2018-04-25 16:44:22 +02:00
Léa Saviot
948efc54c6 [poincare] Remove ELCursor::equivalentPointedSiblingLayout
Change-Id: I6748a502e30efc8f047dcba58e5c50fcdd2fc2fc
2018-04-25 16:44:13 +02:00
Léa Saviot
43e81a6fb3 [escher] setFrame marks as dirty the olf frame minus the new frame.
Change-Id: I0658551541971f9f36a60ef87380f55d7ff148b8
2018-04-25 15:21:06 +02:00
Léa Saviot
8778516fe2 [escher] expressionLayoutFieldDidChangeSize reloads only the modalView
Change-Id: Ib406c7d10e2befae9d660e025c84df58a2e9b70c
2018-04-25 15:15:12 +02:00
Léa Saviot
832f7c3c74 [escher] Only ExpressionLayoutField::reload calls eLFdidChangeSize
Change-Id: I0e75c53750dfb2213b926b3d7e988bb6b37f9d05
2018-04-25 15:14:08 +02:00
Léa Saviot
61491fffe3 [poincare] Fix parser. Did not handle -1-2-3 (would give -1-(2-3))
Change-Id: I490bc95898cbd502b68ebb0817ff9d830946c9d1
2018-04-25 15:01:40 +02:00
Léa Saviot
96c24b1d63 [kandinsky] Simplify code of Kandinsky tests
Change-Id: Ib5c716a5c8ed8d1ef8849475f8bc71076f91c6bc
2018-04-25 13:58:43 +02:00
Léa Saviot
2aa9b6947e [kandinsky] Add test cases for KDRect::differencedWith
Change-Id: I27371f94e590cb75712154b47efe4db27d0a082d
2018-04-25 13:58:43 +02:00
Léa Saviot
34d6028882 [kandinsky] Add method KDRect::differencedWith(const KDRect & other)
Change-Id: Ib6c61bbd3bffc90bc3e704a7133eae0731500864
2018-04-25 13:58:43 +02:00
Léa Saviot
9f09ee8339 [escher] Remove big modal view drawing hack.
Change-Id: I09b0d9ee1db8db9a736577770f540e69cc78d660
2018-04-25 13:58:43 +02:00
Léa Saviot
d9c89ea0c9 [escher] ModalViewCtrlr: don't dirty main view when dislaying sibling
Change-Id: I7d1a555055bc3d9a3f9801e96c792d45ab2011d4
2018-04-25 13:58:43 +02:00
Léa Saviot
733473beb8 [poincare] Remove comment.
Change-Id: If12942c2482756673e756fc8bcc6b809d2978e92
2018-04-25 13:58:43 +02:00
Léa Saviot
d51ddc55a1 [apps/sequence] Put a condition on SeqType to get FirstInitialCondName
This condition was removed non-intentionnally by a previous commit

Change-Id: I643351b3ca965405753c0757971871c71838e405
2018-04-25 13:58:42 +02:00
Léa Saviot
a27963597b [apps] More generic VariableBoxController methods
Before, the class differentiated between TextField and
ExpressionLayoutField

Change-Id: I1fce8bb650a0bfccb11ddf61d05335e452374abb
2018-04-25 13:58:42 +02:00
Léa Saviot
f6c3f7b0e9 [poincare] Remove old expression_view_with_cursor.h file
Change-Id: I0f96e79fdf2d374c88c0f590101ff4e7205dcb54
2018-04-25 13:58:42 +02:00
Léa Saviot
772187725c [escher/poincare] Missing "override" keywords.
Change-Id: Icbb9e25cb0983eb27913a4a7efd358a971664b7e
2018-04-25 13:58:42 +02:00
Léa Saviot
a5c50f8887 [apps] Fix function name that was the same as virtual function.
Change-Id: Idec43b9427571dbd5752ac551424447cbdb08d27
2018-04-25 13:58:42 +02:00
Léa Saviot
99b320c754 [poincare] Factorize Parenthesis/SquareBracket layout in BracketLayout.
Change-Id: I2aeddb950803f460b75e6e9a0efd3c0e2f16164e
2018-04-25 13:58:42 +02:00
Léa Saviot
e622d6aa43 [poincare] Rename BracketLayout -> SquareBracketLayout
Change-Id: I1c2c41a2dcdd0209f37b3a4f3317c91a52122117
2018-04-25 13:58:42 +02:00
Léa Saviot
51e986606c [poincare] Factorize Left/RightBracket layouts code.
Change-Id: I8708b9e0cfe0154232184f01afd532d4879b4cc0
2018-04-25 13:58:42 +02:00
Léa Saviot
3dc55230f7 [poincare] Remove methods from CondensedSumLayout.
This layout is never used with a cursor, so many methods can just be
assert(false).

Change-Id: I3591d8f1983e402130f55fa1875436f24dff637d
2018-04-25 13:58:42 +02:00
Léa Saviot
6dd2057593 [apps/calculation] Re-arrange private attributes.
Change-Id: I024e17fac84d8e3025745267ad488db83eeeb928
2018-04-25 13:58:42 +02:00
Léa Saviot
861aea6100 [poincare] LinearEdition mode by default.
Change-Id: I6783e695b4918424829fb0412f29eea22967ce92
2018-04-25 13:58:42 +02:00
Léa Saviot
8afed56d61 [poincare] Fix subscript layout position and baseline.
Change-Id: I3c2efdfed6440b0bcb6fe98400ae2c5f32315396
2018-04-25 13:58:42 +02:00
Léa Saviot
c929390a44 [poincare] Fix SequenceLayout navigation
Change-Id: I0a263343d8048b8924872c2d1119b2d1c4f5f09b
2018-04-25 13:58:42 +02:00
Léa Saviot
9ea40cf5a1 [poincare] Better differentiation between cursor and AbsoluteValueLayout
Change-Id: Idbffc844b41fbc1ac940ea155c1b89245bb8aefe
2018-04-25 13:58:42 +02:00
Léa Saviot
4e16515344 [poincare] Do not insert an empty base for power layouts.
This should be done only if the power is added to an horizontal layout
with no child.

Change-Id: I5f2f501420da127a2ed42d2b01042ec5968f488f
2018-04-25 13:58:42 +02:00
Léa Saviot
0ae7c8a723 [xnt] Insert the right XNT char.
Change-Id: Ibc91a2ece310313fb368a68483c5a1b6fe14aad2
2018-04-25 13:58:42 +02:00
Léa Saviot
fbb2df7fc8 [poincare/tests] Add simple unary minus tests.
Change-Id: I8fe2fe2578faf40feef4f11f19d9b9331d99020b
2018-04-25 13:58:33 +02:00
Léa Saviot
fc357a27ee [parser] Fix Unary minus.
-1-7 would give +6 becaused it was parsed as -(1-7).

Change-Id: Iff98a2ee52ff57c5ab47433aa208dd5fa4c6d3d6
2018-04-23 17:18:56 +02:00
Léa Saviot
fd3a2c3cbc [apps/code] Use a special char to position the cursor in Python commands
Change-Id: I7ae3d6098160212d8683a671c78d3bdb937fb701
2018-04-23 17:18:56 +02:00
Léa Saviot
912d084130 [escher] Fix textfield edition when initial text.
Change-Id: Ieee10ec6fcbe6464dee2748de033f269169789d9
2018-04-23 17:18:56 +02:00
Léa Saviot
13ae1d2545 [apps/escher/toolbox] handleEventWithText for all responders.
This makes the code in the various toolbox more generic. The arguments
of the text to insert are each replaced by a Ion::Charset::Empty.
These Empty chars are used to create layouts in ExpressionLayoutFields,
and to compute the position of the cursor in other fields, before being
removed.

Change-Id: Ie81c1e394b06fef2ab801ccff919d6550f70ec30
2018-04-23 17:18:48 +02:00
Léa Saviot
643aa89f74 [poincare] Fix hideEmptyLayoutIfNeeded
Change-Id: Id535f49bb9a7b343c05e7d2f24264aeb8e531d85
2018-04-23 11:34:01 +02:00
Léa Saviot
e5cabe6bda [escher] Fix ExpressionLayoutField::hasText()
Change-Id: I1e0bb0f7dfea6f6b35bbc3ea7374891ea75f48f1
2018-04-23 11:34:01 +02:00
Léa Saviot
ad65ce2617 [apps/calculation] Removed overrided ExpressionField constructor.
Change-Id: Id893bb89c9f1282b7fc9e94acc0324a66c749a0c
2018-04-23 11:34:01 +02:00
Léa Saviot
5205d35973 [apps/calculation] Remove asserts that use obsolete functions
Change-Id: I27252b48abb71755335e97d0903453e135247903
2018-04-23 11:34:01 +02:00
Léa Saviot
c3433da2e2 [apps/calculation] Factorize some code.
Change-Id: Id217a1d898c7100172a70cd1fedcf3573c2f68b9
2018-04-23 11:34:01 +02:00
Léa Saviot
d436e06a73 [escher] ~InputViewController and rule of 5
Change-Id: Iec7a3f005df01c59162c8898e136d94f7e69c236
2018-04-23 11:34:01 +02:00
Léa Saviot
6d7464707d [apps/calculation] Fix member initialization order.
Change-Id: I16788edf23b9c2d70a781db5ad90ebfd67b926e7
2018-04-23 11:34:01 +02:00
Léa Saviot
5c2322a5a4 [apps/calculation] Rule of 5 in EditExpressionController::ContentView
Change-Id: I92ee8ee934c66674bb983780a5d8084a1562accf
2018-04-23 11:34:00 +02:00
Léa Saviot
ce056e085b [escher] Remove View::frame(), create TextCursorView::frame()
Change-Id: I69c1aa5e94d93d2832564040abcca62bddc377ae
2018-04-23 11:34:00 +02:00
Léa Saviot
e0356e18e7 [poincare] Inline empty method.
Change-Id: I926252df6fefe61e61402a856656da3b3b6aadaf
2018-04-23 11:34:00 +02:00
Léa Saviot
117a6d460a [poincare] Stop exposing text/expressionlayout fields in ExpressionField
Change-Id: Ic1afb3f7c1f6bff5ea3bedc6f96bef986b74f6a8
2018-04-23 11:33:53 +02:00
Léa Saviot
894080f1ab [apps/escher] EVWithCursor becomes ELField::ContentView
Change-Id: I719218e4d1d360800e0f1ef3eebeea774c8d5660
2018-04-23 09:41:20 +02:00