BreizhHardware/jfa-go
1
0
Fork 0
mirror of https://github.com/hrfee/jfa-go.git synced 2026-01-18 16:47:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

settings: fix weirdness on mobile

Browse Source 
the check and button's onclick were both firing occasionally, so added
check to button.onclick that the target isn't the check or it's icon, as
I did for the invite details toggle.
This commit is contained in:
Harvey Tindall
2025-11-25 21:03:20 +00:00
parent 909614c3e7
commit 875387166e
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ts/modules/settings.ts
View File

@@ -542,6 +542,7 @@ class groupButton {
get open(): boolean { return this._check.checked; }
set open(v: boolean) {
console.trace("set", v);
this.openCloseWithAnimation(v);
}
@@ -581,7 +582,7 @@ class groupButton {
this._dropdown.addEventListener("transitionend", mainTransitionEnd);
this._dropdown.style.maxHeight = "0";
this._dropdown.style.opacity = "0";
}
};
// Hide the scrollbar while we animate
this._parentSidebar.style.overflowY = "hidden";
// Disabling transitions then going from 9999 - scrollHeight doesn't work in firefox to me,
@@ -634,8 +635,8 @@ class groupButton {
this._icon = this._button.querySelector("i.icon");
this._check = this._button.querySelector("input[type=checkbox]") as HTMLInputElement;
this._button.onclick = () => {
this.open = !this.open;
this._button.onclick = (event: Event) => {
if (event.target != this._icon && event.target != this._check) this.open = !this.open;
};
this._check.onclick = () => {
this.open = this.open;