BreizhHardware/memoizee
1
0
Fork 0
mirror of https://github.com/BreizhHardware/memoizee.git synced 2026-01-18 16:37:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Support finally with done

Browse Source 
Still allow to force `then` usage with implementations that have
primitive `done` support
This commit is contained in:
Mariusz Nowak
2016-07-07 14:34:06 +02:00
parent 1a102b3143
commit 22e3647bd1
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ext/promise.js
View File

@@ -8,9 +8,16 @@ var objectMap = require('es5-ext/object/map')
, create = Object.create, hasOwnProperty = Object.prototype.hasOwnProperty;
require('../lib/registered-extensions').promise = function (ignore, conf) {
require('../lib/registered-extensions').promise = function (mode, conf) {
var waiting = create(null), cache = create(null), promises = create(null);
// We may want to force 'then' usage, when promise implementation that used:
// - implements both `done` and `finally`
// - Throws rejection reason unconditionally when `done` is called with no onFailue callback
// on rejected promise (even though some other `then` or `done` call may have processed the
// error)
var forceThenMode = (mode === 'then');
// After not from cache call
conf.on('set', function (id, ignore, promise) {
if (!isPromise(promise)) {
@@ -34,10 +41,20 @@ require('../lib/registered-extensions').promise = function (ignore, conf) {
delete promises[id];
conf.delete(id);
};
// Use 'finally' and not rejection callback (on 'done' or 'then') to not register error
// processing.
// Additionally usage of 'finally' should take place if implementation
// supports promise cancelation (then no `then` or `done` callbacks are invoked)
var hasFinally = (typeof promise.finally === 'function');
if (typeof promise.done === 'function') {
if (!forceThenMode && (typeof promise.done === 'function')) {
// Optimal promise resolution
promise.done(onSuccess, onFailure);
if (hasFinally) {
promise.done(onSuccess);
promise.finally(onFailure);
} else {
promise.done(onSuccess, onFailure);
}
} else {
// Be sure to escape error swallowing
if (hasFinally) {