UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-19 22:00:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps/*/editable_cell_table_view_controller] Factor table view margin values

Browse Source
This commit is contained in:
Ruben Dashyan
2019-09-05 13:21:31 +02:00
parent 0911672224
commit 0631ed77b5
4 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/shared/editable_cell_table_view_controller.h
View File

@@ -22,6 +22,8 @@ public:
void didBecomeFirstResponder() override;
protected:
static constexpr KDCoordinate k_cellHeight = 20;
static constexpr KDCoordinate k_margin = Metric::TableSeparatorThickness;
static constexpr KDCoordinate k_scrollBarMargin = Metric::CommonRightMargin;
/* Editable cell might be not wide enough to display
* LargeNumberOfSignificantDigits, we update the buffer to the column width. */
size_t cellBufferSize(int i) {

2
apps/shared/store_controller.h
View File

@@ -60,8 +60,6 @@ protected:
// Responder
void didBecomeFirstResponder() override;
private:
static constexpr KDCoordinate k_margin = Metric::TableSeparatorThickness;
static constexpr KDCoordinate k_scrollBarMargin = Metric::CommonRightMargin;
static constexpr KDCoordinate k_formulaInputHeight = 31;
int numberOfSubviews() const override { return 1 + m_displayFormulaInputView; }
View * subviewAtIndex(int index) override;

5
apps/shared/values_controller.cpp
View File

@@ -17,10 +17,7 @@ ValuesController::ValuesController(Responder * parentResponder, ButtonRowControl
m_abscissaParameterController(this)
{
m_selectableTableView.setVerticalCellOverlap(0);
m_selectableTableView.setTopMargin(k_topMargin);
m_selectableTableView.setRightMargin(k_rightMargin);
m_selectableTableView.setBottomMargin(k_bottomMargin);
m_selectableTableView.setLeftMargin(k_leftMargin);
m_selectableTableView.setMargins(k_margin, k_scrollBarMargin, k_scrollBarMargin, k_margin);
m_selectableTableView.setBackgroundColor(Palette::WallScreenDark);
}

4
apps/shared/values_controller.h
View File

@@ -34,10 +34,6 @@ public:
Responder * defaultController() override;
void viewWillAppear() override;
void viewDidDisappear() override;
static constexpr KDCoordinate k_topMargin = Metric::CommonSmallMargin;
static constexpr KDCoordinate k_bottomMargin = Metric::CommonSmallMargin;
static constexpr KDCoordinate k_leftMargin = Metric::CommonSmallMargin;
static constexpr KDCoordinate k_rightMargin = Metric::CommonRightMargin;
static constexpr KDCoordinate k_abscissaCellWidth = 100;
static constexpr KDCoordinate k_ordinateCellWidth = 100;