UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-25 16:50:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare] No clone on Integer: copy assignment and copy constructor

Browse Source 
automatically clone
This commit is contained in:
Émilie Feral
2018-09-03 14:37:29 +02:00
parent 9197957365
commit 0a6e2bbf63
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
poincare/src/arithmetic.cpp
View File

@@ -7,7 +7,7 @@ Integer Arithmetic::LCM(const Integer & a, const Integer & b) {
if (a.isZero() || b.isZero()) {
return Integer(0);
}
Integer signResult = Integer::Division(Integer::Multiplication(static_cast<Integer>(a.clone()), static_cast<Integer>(b.clone())), GCD(a, b)).quotient;
Integer signResult = Integer::Division(Integer::Multiplication(static_cast<Integer>(a), static_cast<Integer>(b)), GCD(a, b)).quotient;
//TODO Check if clone required or not
signResult.setNegative(false);
return signResult;
@@ -15,11 +15,11 @@ Integer Arithmetic::LCM(const Integer & a, const Integer & b) {
Integer Arithmetic::GCD(const Integer & a, const Integer & b) {
if (a.isInfinity() || b.isInfinity()) {
return Integer::Overflow();
return Integer::Overflow(false);
}
Integer i = static_cast<Integer>(a.clone());
Integer j = static_cast<Integer>(b.clone());
Integer i = a;
Integer j = b;
i.setNegative(false);
j.setNegative(false);
do {
@@ -45,7 +45,7 @@ void Arithmetic::PrimeFactorization(const Integer & n, Integer outputFactors[],
assert(!n.isInfinity());
// Compute the absolute value of n
Integer m = static_cast<Integer>(n.clone());
Integer m = n;
m.setNegative(false);
/* First we look for prime divisors in the table primeFactors (to speed up

4
poincare/src/binomial_coefficient.cpp
View File

@@ -90,8 +90,8 @@ Expression BinomialCoefficient::shallowReduce(Context & context, Preferences::An
Rational r0 = static_cast<Rational>(c0);
Rational r1 = static_cast<Rational>(c1);
Integer n = static_cast<Integer>(r0.signedIntegerNumerator().clone());
Integer k = static_cast<Integer>(r1.signedIntegerNumerator().clone());
Integer n = r0.signedIntegerNumerator();
Integer k = r1.signedIntegerNumerator();
if (n.isLowerThan(k)) {
Expression result = Undefined();
replaceWithInPlace(result);