UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/power] Fix infinite loop in reduction

Browse Source 
Fix the broken simplification test 1/identity(2)^500
This commit is contained in:
Léa Saviot
2020-06-03 11:39:37 +02:00
committed by Émilie Feral
parent 55ae258653
commit 0c040a7db6
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
poincare/src/power.cpp
View File

@@ -439,6 +439,12 @@ Expression Power::shallowReduce(ExpressionNode::ReductionContext reductionContex
if (exponent.isNegative()) {
index.setSign(ExpressionNode::Sign::Positive, reductionContext);
Expression reducedPositiveExponentMatrix = shallowReduce(reductionContext);
if (reducedPositiveExponentMatrix.type() == ExpressionNode::Type::Power) {
/* The shallowReduce did not work, stop here so we do not get in an
* infinite loop. */
static_cast<Power &>(reducedPositiveExponentMatrix).childAtIndex(1).setSign(ExpressionNode::Sign::Negative, reductionContext);
return reducedPositiveExponentMatrix;
}
Expression dummyExpression = Undefined::Builder();
MatrixInverse inv = MatrixInverse::Builder(dummyExpression);
reducedPositiveExponentMatrix.replaceWithInPlace(inv);