UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-22 15:20:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare] Multiplication::shallowReduce: simplify implementation!

Browse Source 
(recursivelyMatches all children is equivalent to recursivelyMatches on
the current node)
This commit is contained in:
Émilie Feral
2020-02-03 17:25:55 +01:00
committed by Léa Saviot
parent ff438cbea8
commit 1484dbc5d4
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
poincare/src/multiplication.cpp
View File

@@ -766,13 +766,7 @@ Expression Multiplication::privateShallowReduce(ExpressionNode::ReductionContext
const Expression c = childAtIndex(0);
if (c.type() == ExpressionNode::Type::Rational && static_cast<const Rational &>(c).isZero()) {
// Check that other children don't match inf or unit
bool infiniteOrUnitFactor = false;
for (int i = 1; i < numberOfChildren(); i++) {
infiniteOrUnitFactor = childAtIndex(i).recursivelyMatches([](const Expression e, Context * context) { return Expression::IsInfinity(e,context) || e.type() == ExpressionNode::Type::Unit; }, reductionContext.context());
if (infiniteOrUnitFactor) {
break;
}
}
bool infiniteOrUnitFactor = recursivelyMatches([](const Expression e, Context * context) { return Expression::IsInfinity(e,context) || e.type() == ExpressionNode::Type::Unit; }, reductionContext.context());
if (!infiniteOrUnitFactor) {
replaceWithInPlace(c);
return c;