UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[escher] SelectableTableView: fix delegate notification when

Browse Source 
deselecting table view

This fixes the following bug: input 1.2/2, OK, up, down, the exact ouput
is still displayed but should have toggled
This commit is contained in:
Émilie Feral
2020-06-26 15:59:00 +02:00
parent db331e054a
commit 1da2f23914
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
escher/src/selectable_table_view.cpp
View File

@@ -71,6 +71,7 @@ void SelectableTableView::deselectTable(bool withinTemporarySelection) {
selectRow(-1);
if (m_delegate) {
m_delegate->tableViewDidChangeSelection(this, previousSelectedCellX, previousSelectedCellY, withinTemporarySelection);
m_delegate->tableViewDidChangeSelectionAndDidScroll(this, previousSelectedCellX, previousSelectedCellY, withinTemporarySelection);
}
}
@@ -87,17 +88,20 @@ bool SelectableTableView::selectCellAtLocation(int i, int j, bool setFirstRespon
selectColumn(i);
selectRow(j);
/* The delegate is notified:
* - after changing the selected cell but before scrolling: for instance,
* ExpressionModelListController needs to update its memoized cell before
* being able to scroll;
* - after scrolling: for instance, the calculation history table might
* change its cell content when selected (outup toggling, ellipsis toggling)
* and thus need to access the right used cell - which is defined only
* after scrolling.
*/
if (m_delegate) {
m_delegate->tableViewDidChangeSelection(this, previousX, previousY, withinTemporarySelection);
}
/* We need to scroll:
* - After notifying the delegate. For instance,
* ExpressionModelListController needs to update its memoized cell
* height values before any scroll.
* - Before setting the first responder. If the first responder is a view, it
* might change during the scroll. */
if (selectedRow() >= 0) {
scrollToCell(selectedColumn(), selectedRow());
}