UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-20 14:20:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare] Addition: shallowBeautify sorts its children in decreasing

Browse Source 
order: 1+x+x^2 --> x^2+x+1
This commit is contained in:
Émilie Feral
2018-12-27 15:09:20 +01:00
committed by Léa Saviot
parent fe8825df35
commit 2ea39fcaa4
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
poincare/src/addition.cpp
View File

@@ -99,6 +99,11 @@ Expression Addition::shallowBeautify(Context & context, Preferences::ComplexForm
* Last but not least, special care must be taken when iterating over children
* since we may remove some during the process. */
/* Sort children in decreasing order:
* 1+x+x^2 --> x^2+x+1
* 1+R(2) --> R(2)+1 */
sortChildrenInPlace([](const ExpressionNode * e1, const ExpressionNode * e2, bool canBeInterrupted) { return ExpressionNode::SimplificationOrder(e2, e1, canBeInterrupted); }, true);
for (int i = 0; i < numberOfChildren(); i++) {
// Try to make the child i positive if any negative numeral factor is found
Expression subtractant = childAtIndex(i).makePositiveAnyNegativeNumeralFactor(context, complexFormat, angleUnit, ExpressionNode::ReductionTarget::User);