UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/unit] Dimension::Vector::FromBaseUnits accepts only products of powers of base units

Browse Source 
and no other factor at all
This commit is contained in:
Ruben Dashyan
2020-02-24 16:51:57 +01:00
committed by Émilie Feral
parent 394e86a28a
commit 2f708cc36c
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
poincare/src/unit.cpp
View File

@@ -127,13 +127,8 @@ Unit::Dimension::Vector<Integer> UnitNode::Dimension::Vector<Integer>::FromBaseU
factor = factor.childAtIndex(0);
}
// FIXME Remove this once this case may not occur anymore
// The leading factors may not be of Unit type
if (factor.type() != ExpressionNode::Type::Unit) {
continue;
}
// Fill the vector with the unit's exponent
assert(factor.type() == ExpressionNode::Type::Unit);
const ptrdiff_t indexInTable = static_cast<UnitNode *>(factor.node())->dimension() - Unit::DimensionTable;
assert(0 <= indexInTable && indexInTable < NumberOfBaseUnits);
vector.setCoefficientAtIndex(indexInTable, exponent);