UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-20 01:08:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/arithmetic] Shortcut the LCM and GCD computation if equal

Browse Source 
This fixes: LCM(7.88861e+169, 7.88861e+169), which overflowed at some
point during the computation
This commit is contained in:
Léa Saviot
2020-03-12 16:55:18 +01:00
committed by RubenNumworks
parent 97d94d9e56
commit 313cbf6767
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
poincare/src/arithmetic.cpp
View File

@@ -7,6 +7,9 @@ Integer Arithmetic::LCM(const Integer & a, const Integer & b) {
if (a.isZero() || b.isZero()) {
return Integer(0);
}
if (a.isEqualTo(b)) {
return a;
}
Integer signResult = Integer::Division(Integer::Multiplication(a, b), GCD(a, b)).quotient;
signResult.setNegative(false);
return signResult;
@@ -16,7 +19,9 @@ Integer Arithmetic::GCD(const Integer & a, const Integer & b) {
if (a.isOverflow() || b.isOverflow()) {
return Integer::Overflow(false);
}
if (a.isEqualTo(b)) {
return a;
}
Integer i = a;
Integer j = b;
i.setNegative(false);