UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-18 16:27:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

[statistics] Fix glitch with histogram parameters

Browse Source 
In the window to change the histogram parameters, it was possible to set
a rectangle width that was considered valid, but would make the starting
abscissa invalid, while triggering no error message. The message would
only show if the user closed the window and opened it again.
e.g. : Set a series with only one value 1e10
       Change its starting abscissa to 0
       Change its rectangle width to 1, confirm and close the menu
       Re-open the menu, a message appears, and stays onscreen when
leaving the menu.
This commit is contained in:
Gabriel Ozouf
2020-12-28 16:19:16 +01:00
committed by EmilieNumworks
parent ea4770fc81
commit 5ce5f4fbac
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/statistics/histogram_parameter_controller.cpp
View File

@@ -90,7 +90,7 @@ bool HistogramParameterController::setParameterAtIndex(int parameterIndex, doubl
// The number of bars cannot be above the max
assert(DoublePairStore::k_numberOfSeries > 0);
for (int i = 0; i < DoublePairStore::k_numberOfSeries; i++) {
const double min = setBarWidth ? m_store->minValue(i) : nextFirstDrawnBarAbscissa;
const double min = std::min(m_store->minValue(i), nextFirstDrawnBarAbscissa);
double numberOfBars = std::ceil((m_store->maxValue(i) - min)/nextBarWidth);
if (numberOfBars > Store::k_maxNumberOfBars) {
Container::activeApp()->displayWarning(I18n::Message::ForbiddenValue);