UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[shared] ExpressionModel tidy pool of its Expression & Layout when

Browse Source 
tidying
This commit is contained in:
Émilie Feral
2018-09-06 17:03:27 +02:00
parent 03dcb58096
commit 6ea91ecc4e
1 changed files with 4 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
apps/shared/expression_model.cpp
View File

@@ -47,33 +47,13 @@ void ExpressionModel::setContent(const char * c) {
/* We cannot call tidy here because tidy is a virtual function and does not
* do the same thing for all children class. And here we want to delete only
* the m_layout and m_expression. */
// TODO: the previous expression and layout are going to be destroyed as soon as we call expression(). Should we optimize this?
#if 0
if (!m_layoutRef.isUninitialized()) {
m_layoutRef = LayoutRef();
}
if (m_expression != nullptr) {
delete m_expression;
m_expression = nullptr;
}
#endif
m_layoutRef = LayoutRef();
m_expression = Expression();
}
void ExpressionModel::tidy() {
// TODO: what do we want to do? Delete layout and ref?
#if 0
m_layoutRef = LayoutRef(); ?
m_expression = Expression(); ?
if (!m_layoutRef.isUninitialized()) {
m_layoutRef = LayoutRef();
}
if (m_expression != nullptr) {
delete m_expression;
m_expression = nullptr;
}
#endif
m_layoutRef = LayoutRef();
m_expression = Expression();
}
}