UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[function_graph_controller] Remove yRangeForCursorFirstMove

Browse Source 
This method, that prevented the graph from panning when moving the
cursor for the first time, caused more problems than it solved.
For instance, the graph for 1/(1-x) was not symmetrical because of it.

Change-Id: Ibb22e38ec0ace6b219c0e42dda481c98b5f717f0
This commit is contained in:
Gabriel Ozouf
2020-10-15 15:06:01 +02:00
committed by Émilie Feral
parent 3ba4f974f7
commit 71e7070657
1 changed files with 0 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
apps/shared/function_graph_controller.cpp
View File

@@ -165,44 +165,9 @@ void FunctionGraphController::interestingRanges(InteractiveCurveViewRange * rang
range->setXMax(xMax);
range->setYMin(yMin);
range->setYMax(yMax);
yRangeForCursorFirstMove(range);
} else {
range->setNullRange();
}
}
void FunctionGraphController::yRangeForCursorFirstMove(InteractiveCurveViewRange * range) const {
Poincare::Context * context = textFieldDelegateApp()->localContext();
assert(functionStore()->numberOfActiveFunctions() > 0);
int functionsCount = functionStore()->numberOfActiveFunctions();
float cursorStep = range->xGridUnit() / k_numberOfCursorStepsInGradUnit;
float y[2]; // Left and Right
bool normalized = range->isOrthonormal();
constexpr float maximalExpansion = 10.f;
float yRange = range->yMax() - range->yMin();
for (int i = 0; i < functionsCount; i++) {
ExpiringPointer<Function> f = functionStore()->modelForRecord(functionStore()->activeRecordAtIndex(i));
for (int i = 0; i < 2; i++) {
float step = cursorStep * (i == 0 ? -1 : 1);
y[i] = f->evaluateXYAtParameter(range->xCenter() + step, context).x2();
if (std::isfinite(y[i])) {
if (y[i] < range->yMin() && (range->yMax() - y[i]) < maximalExpansion * yRange) {
range->setYMin(y[i]);
}
if (y[i] > range->yMax() && (y[i] - range->yMin()) < maximalExpansion * yRange) {
range->setYMax(y[i]);
}
}
}
}
if (normalized) {
range->normalize();
}
}
}