UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[code] Fix 'use address after scope' issue

Browse Source 
We used an array that was out of scope in PythonToolbox.
This commit is contained in:
Émilie Feral
2019-06-14 09:27:23 -04:00
committed by LeaNumworks
parent bedc09f9f1
commit 9c2fc84cd0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/code/python_toolbox.cpp
View File

@@ -361,9 +361,10 @@ bool PythonToolbox::selectLeaf(int selectedRow) {
m_selectableTableView.deselectTable();
ToolboxMessageTree * node = (ToolboxMessageTree *)m_messageTreeModel->children(selectedRow);
const char * editedText = I18n::translate(node->insertedText());
// strippedEditedText array needs to be in the same scope as editedText
char strippedEditedText[k_maxMessageSize];
if (node->stripInsertedText()) {
int strippedEditedTextMaxLength = strlen(editedText)+1;
char strippedEditedText[k_maxMessageSize];
assert(strippedEditedTextMaxLength <= k_maxMessageSize);
Shared::ToolboxHelpers::TextToInsertForCommandMessage(node->insertedText(), strippedEditedText, strippedEditedTextMaxLength, true);
editedText = strippedEditedText;