UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare] Multiplication::shallowBeautify: removeUnit can only be

Browse Source 
called on reduced expression

This fixes the following bug: input i+10*sqrt(i)
This commit is contained in:
Émilie Feral
2020-05-20 11:38:37 +02:00
parent a4c591dea6
commit b596488a01
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
poincare/src/multiplication.cpp
View File

@@ -356,13 +356,15 @@ Expression Multiplication::shallowBeautify(ExpressionNode::ReductionContext redu
}
Expression result;
Expression self = *this;
// Step 2: Handle the units
Expression self = *this;
Expression units;
self = removeUnit(&units);
if (hasUnit()) {
Expression units;
self = deepReduce(reductionContext); // removeUnit has to be called on reduced expression
self = removeUnit(&units);
if (!units.isUninitialized()) {
assert(!units.isUninitialized());
ExpressionNode::UnitConversion unitConversionMode = reductionContext.unitConversion();
if (unitConversionMode == ExpressionNode::UnitConversion::Default) {
/* Step 2a: Recognize derived units