UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[solver] Fix memory leak: the static hierarchy and dynamic hierarchy

Browse Source 
used to clone the operands given as parameters.
This commit is contained in:
Émilie Feral
2018-06-11 18:08:01 +02:00
parent 031ca760c0
commit b75bd957fb
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/solver/equation_store.cpp
View File

@@ -237,13 +237,13 @@ EquationStore::Error EquationStore::oneDimensialPolynomialSolve(Expression * exa
Expression::Simplify(&delta, *context);
if (delta->isRationalZero()) {
// if delta = 0, x0=x1= -b/(2a)
exactSolutions[0] = new Division(new Opposite(coefficients[1], false), new Multiplication(new Rational(2), coefficients[2]), false);
exactSolutions[0] = new Division(new Opposite(coefficients[1], false), new Multiplication(new Rational(2), coefficients[2], false), false);
m_numberOfSolutions = 1;
} else {
// x0 = (-b-sqrt(delta))/(2a)
exactSolutions[0] = new Division(new Subtraction(new Opposite(coefficients[1]->clone(), false), new SquareRoot(delta->clone(), false), false), new Multiplication(new Rational(2), coefficients[2]->clone()), false);
exactSolutions[0] = new Division(new Subtraction(new Opposite(coefficients[1]->clone(), false), new SquareRoot(delta->clone(), false), false), new Multiplication(new Rational(2), coefficients[2]->clone(), false), false);
// x1 = (-b+sqrt(delta))/(2a)
exactSolutions[1] = new Division(new Addition(new Opposite(coefficients[1], false), new SquareRoot(delta->clone(), false), false), new Multiplication(new Rational(2), coefficients[2]), false);
exactSolutions[1] = new Division(new Addition(new Opposite(coefficients[1], false), new SquareRoot(delta->clone(), false), false), new Multiplication(new Rational(2), coefficients[2], false), false);
m_numberOfSolutions = 2;
}
exactSolutions[m_numberOfSolutions] = delta;

4
poincare/include/poincare/dynamic_hierarchy.h
View File

@@ -10,8 +10,8 @@ namespace Poincare {
class DynamicHierarchy : public Expression {
public:
DynamicHierarchy();
DynamicHierarchy(const Expression * const * operands, int numberOfOperands, bool cloneOperands = true);
DynamicHierarchy(const Expression * operand1, const Expression * operand2, bool cloneOperands = true) :
DynamicHierarchy(const Expression * const * operands, int numberOfOperands, bool cloneOperands);
DynamicHierarchy(const Expression * operand1, const Expression * operand2, bool cloneOperands) :
DynamicHierarchy(ExpressionArray(operand1, operand2).array(), 2, cloneOperands) {}
~DynamicHierarchy();
DynamicHierarchy(const DynamicHierarchy & other) = delete;

4
poincare/include/poincare/static_hierarchy.h
View File

@@ -10,8 +10,8 @@ template<int T>
class StaticHierarchy : public Expression {
public:
StaticHierarchy();
StaticHierarchy(const Expression * const * operands, bool cloneOperands = true);
StaticHierarchy(const Expression * expression, bool cloneOperands = true); // Specialized constructor for StaticHierarchy<1>
StaticHierarchy(const Expression * const * operands, bool cloneOperands);
StaticHierarchy(const Expression * expression, bool cloneOperands); // Specialized constructor for StaticHierarchy<1>
StaticHierarchy(const Expression * expression1, const Expression * expression2, bool cloneOperands = true); // Specialized constructor for StaticHierarchy<2>
~StaticHierarchy();
StaticHierarchy(const StaticHierarchy & other) = delete;