UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-18 21:30:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[escher] View: remove useless virtual destructor

Browse Source
This commit is contained in:
Émilie Feral
2020-05-05 10:51:41 +02:00
committed by LeaNumworks
parent a07ab8015e
commit c955f45457
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
escher/include/escher/view.h
View File

@@ -31,18 +31,11 @@ class View {
friend class Shared::RoundCursorView;
public:
View() : m_frame(KDRectZero), m_superview(nullptr), m_dirtyRect(KDRectZero) {}
virtual ~View() {
for (int i = 0; i < numberOfSubviews(); i++) {
View * subview = subviewAtIndex(i);
if (subview != nullptr) {
subview->m_superview = nullptr;
}
}
}
View(View&& other) = default;
View(const View& other) = delete;
View& operator=(const View& other) = delete;
View& operator=(View&& other) = delete;
void resetSuperview() {
m_superview = nullptr;
}
@@ -90,6 +83,12 @@ private:
KDPoint absoluteOrigin() const;
KDRect absoluteVisibleFrame() const;
/* At destruction, subviews aren't notified that their own pointer
* 'm_superview' is outdated. This is not an issue since all view hierarchy
* is created or destroyed at once: when the app is packed or unpacked. The
* view and its subviews are then destroyed concomitantly.
* Otherwise, we would just have to implement the destructor to notify
* subviews that 'm_superview = nullptr'. */
View * m_superview;
KDRect m_dirtyRect;
};