UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/multiplication] Factoring undef power

Browse Source 
When factoring 1^inf * 1^-inf with Multiplication::factorizeBase, an
Undef factor would appear an be carried into the reduced multiplication.
We escape early in this situation by returning Undef.

Change-Id: Id826ad3cc131349e5bb460f7a8c82fe606294b97
This commit is contained in:
Gabriel Ozouf
2020-08-31 11:43:42 +02:00
committed by Émilie Feral
parent 59d5adace3
commit d6c7b2b1ac
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
poincare/src/multiplication.cpp
View File

@@ -731,6 +731,11 @@ Expression Multiplication::privateShallowReduce(ExpressionNode::ReductionContext
}
if (shouldFactorizeBase) {
factorizeBase(i, i+1, reductionContext);
/* An undef term could have appeared when factorizing 1^inf and 1^-inf
* for instance. In that case, we escape and return undef. */
if (childAtIndex(i).isUndefined()) {
return replaceWithUndefinedInPlace();
}
continue;
}
} else if (TermHasNumeralBase(oi) && TermHasNumeralBase(oi1) && TermsHaveIdenticalExponent(oi, oi1)) {