UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-01-19 00:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

[apps] Avoid unsigned/signed comparison: storeChecksumAtIndex takes an

Browse Source 
int as parameter
This commit is contained in:
Émilie Feral
2020-04-06 13:33:38 +02:00
committed by LeaNumworks
parent 154625a945
commit e1d7b6bb04
7 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/regression/graph_controller.cpp
View File

@@ -351,7 +351,7 @@ uint32_t GraphController::modelVersion() {
return m_store->storeChecksum();
}
uint32_t GraphController::modelVersionAtIndex(size_t i) {
uint32_t GraphController::modelVersionAtIndex(int i) {
assert(i < numberOfMemoizedVersions());
return *(m_store->seriesChecksum() + i);
}

2
apps/regression/graph_controller.h
View File

@@ -43,7 +43,7 @@ private:
// InteractiveCurveViewController
void initCursorParameters() override;
uint32_t modelVersion() override;
uint32_t modelVersionAtIndex(size_t i) override;
uint32_t modelVersionAtIndex(int i) override;
uint32_t rangeVersion() override;
size_t numberOfMemoizedVersions() const override { return Store::k_numberOfSeries; }
int selectedCurveIndex() const override { return *m_selectedSeriesIndex; }

2
apps/shared/function_graph_controller.cpp
View File

@@ -183,7 +183,7 @@ uint32_t FunctionGraphController::modelVersion() {
return functionStore()->storeChecksum();
}
uint32_t FunctionGraphController::modelVersionAtIndex(size_t i) {
uint32_t FunctionGraphController::modelVersionAtIndex(int i) {
return functionStore()->storeChecksumAtIndex(i);
}

2
apps/shared/function_graph_controller.h
View File

@@ -50,7 +50,7 @@ private:
// InteractiveCurveViewController
bool moveCursorVertically(int direction) override;
uint32_t modelVersion() override;
uint32_t modelVersionAtIndex(size_t i) override;
uint32_t modelVersionAtIndex(int i) override;
uint32_t rangeVersion() override;
size_t numberOfMemoizedVersions() const override { return sNumberOfMemoizedModelVersions; }

2
apps/shared/function_store.cpp
View File

@@ -6,7 +6,7 @@ uint32_t FunctionStore::storeChecksum() {
return Ion::Storage::sharedStorage()->checksum();
}
uint32_t FunctionStore::storeChecksumAtIndex(size_t i) {
uint32_t FunctionStore::storeChecksumAtIndex(int i) {
if (numberOfActiveFunctions() <= i) {
return 0;
}

2
apps/shared/function_store.h
View File

@@ -13,7 +13,7 @@ class FunctionStore : public ExpressionModelStore {
public:
FunctionStore() : ExpressionModelStore() {}
uint32_t storeChecksum();
uint32_t storeChecksumAtIndex(size_t i);
uint32_t storeChecksumAtIndex(int i);
int numberOfActiveFunctions() const {
return numberOfModelsSatisfyingTest(&isFunctionActive, nullptr);
}

2
apps/shared/interactive_curve_view_controller.h
View File

@@ -41,7 +41,7 @@ protected:
virtual void initCursorParameters() = 0;
virtual bool moveCursorVertically(int direction) = 0;
virtual uint32_t modelVersion() = 0;
virtual uint32_t modelVersionAtIndex(size_t i) = 0;
virtual uint32_t modelVersionAtIndex(int i) = 0;
virtual uint32_t rangeVersion() = 0;
bool isCursorVisible();