[calculation] Improve margins of additional results pop-up

This commit is contained in:
Émilie Feral
2019-11-21 15:01:46 +01:00
committed by Léa Saviot
parent 2ebbe5ae25
commit eac83fce0b
3 changed files with 3 additions and 3 deletions

View File

@@ -39,7 +39,7 @@ private:
SelectableTableView m_selectableTableView;
};
constexpr static int k_maxNumberOfAdditionalCalculations = 3;
constexpr static KDCoordinate k_illustrationHeight = 50;
constexpr static KDCoordinate k_illustrationHeight = 100;
ListController m_listController;
// Cells
virtual HighlightCell * illustrationCell() = 0;

View File

@@ -22,7 +22,7 @@ private:
ExpressionView * leftExpressionView() { return &m_leftExpressionView; }
private:
void setLeftViewBackgroundColor(KDColor color) override { m_leftExpressionView.setBackgroundColor(color); }
KDCoordinate leftBaseline() const override { return m_leftExpressionView.layout().isUninitialized() ? m_leftExpressionView.layout().baseline() : 0; }
KDCoordinate leftBaseline() const override { return !m_leftExpressionView.layout().isUninitialized() ? m_leftExpressionView.layout().baseline() : 0; }
KDSize leftMinimalSizeForOptimalDisplay() const override { return m_leftExpressionView.minimalSizeForOptimalDisplay(); }
ExpressionView m_leftExpressionView;
};

View File

@@ -75,7 +75,7 @@ bool HistoryController::handleEvent(Ion::Events::Event event) {
* m_controller->setType(additionalInformationType)*/
if (additionalInfoType == Expression::AdditionalInformationType::Complex) {
m_complexController.fillCalculationStoreFromExpression(calculation->exactOutput());
Container::activeApp()->displayModalViewController(&m_complexController, 0.f, 0.f, Metric::PopUpTopMargin, Metric::PopUpLeftMargin, Metric::PopUpTopMargin, Metric::PopUpRightMargin);
Container::activeApp()->displayModalViewController(&m_complexController, 0.f, 0.f, Metric::CommonTopMargin, Metric::PopUpLeftMargin, 0, Metric::PopUpRightMargin);
}
} else {
m_selectableTableView.deselectTable();