UpsilonNumworks/Upsilon
1
0
Fork 0
mirror of https://github.com/UpsilonNumworks/Upsilon.git synced 2026-03-19 05:40:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[poincare/n_ary_expression] Add TODO about mergeSameTypeChildrenInPlace

Browse Source
This commit is contained in:
Ruben Dashyan
2020-03-24 15:39:35 +01:00
committed by Émilie Feral
parent 965e3b1d9a
commit f224ac31e3
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
poincare/src/addition.cpp
View File

@@ -143,7 +143,10 @@ Expression Addition::shallowReduce(ExpressionNode::ReductionContext reductionCon
}
/* Step 1: Addition is associative, so let's start by merging children which
* are additions. */
* are additions.
* TODO If the parent Expression is an Addition, one should perhaps
* return now and let the parent do the reduction.
*/
mergeSameTypeChildrenInPlace();
const int childrenCount = numberOfChildren();

5
poincare/src/multiplication.cpp
View File

@@ -504,7 +504,10 @@ Expression Multiplication::privateShallowReduce(ExpressionNode::ReductionContext
}
/* Step 1: MultiplicationNode is associative, so let's start by merging children
* which also are multiplications themselves. */
* which also are multiplications themselves.
* TODO If the parent Expression is a Multiplication, one should perhaps
* return now and let the parent do the reduction.
*/
mergeSameTypeChildrenInPlace();
Context * context = reductionContext.context();